Edgewall Software
Modify ↓

Opened 14 years ago

Closed 12 years ago

Last modified 12 years ago

#9366 closed enhancement (fixed)

Permissions screen is confusing when there are large groups

Reported by: batrick Owned by: Oleg Frantsuzov <franoleg@…>
Priority: high Milestone: 1.0
Component: admin/web Version:
Severity: normal Keywords: bitesized patch review
Cc: franoleg@…, osimons, ryano@… Branch:
Release Notes:

Separated permissions and group memberships in the permission admin panel.

API Changes:
Internal Changes:

Description

We use trac with approximately 10 groups and 150 users. Functionally, everything works fine but the permissions screen is confusing because it shows one row per user (so there are approximately 160 rows shown, including the rights for each group).

It would be a fine usability enhancements if group memberships were, in fact, shown by group. In this case, there would be only 10 lines for permissions, and 10 for group memberships.

Attachments (2)

t9366-r1.diff​ (4.0 KB ) - added by Oleg Frantsuzov <franoleg@…> 12 years ago.
Permissions and group membership are displayed as two tables, instead of one (against trunk).
two-tables.png​ (67.8 KB ) - added by Oleg Frantsuzov <franoleg@…> 12 years ago.
A screenshot of separated tables.

Download all attachments as: .zip

Change History (12)

comment:1 by Remy Blank, 14 years ago

Keywords: bitesized added
Milestone: → unscheduled

This sounds like a nice idea.

comment:2 by Oleg Frantsuzov <franoleg@…>, 12 years ago

I'm submitting a patch which implements this proposal (screenshot included). Changes are primarily in the Genshi template, which now lists perms and groups as separate tbodys. Code only places the perms and the groups apart.

Form logic was not modified.

There are some changes in the CSS that I made in order to put subheadings within the table (I wanted the column widths to be the same, hence one table instead of two, a la #9825). I feel these changes can be done better. Any feedback so I can improve the patch?

by Oleg Frantsuzov <franoleg@…>, 12 years ago

Attachment: t9366-r1.diff​ added

Permissions and group membership are displayed as two tables, instead of one (against trunk).

by Oleg Frantsuzov <franoleg@…>, 12 years ago

Attachment: two-tables.png​ added

A screenshot of separated tables.

comment:3 by Oleg Frantsuzov <franoleg@…>, 12 years ago

Keywords: patch review added

comment:4 by Remy Blank, 12 years ago

Milestone: unscheduled → 0.13
Owner: set to Remy Blank
Priority: normal → high

That looks nice! Thanks for the patch.

comment:5 by Oleg Frantsuzov <franoleg@…>, 12 years ago

Cc: franoleg@… added

comment:6 by osimons, 12 years ago

Cc: osimons added

comment:7 by Ryan J Ollos <ryano@…>, 12 years ago

Cc: ryano@… added

comment:8 by Remy Blank, 12 years ago

Resolution: → fixed
Status: new → closed

Improved patch applied in [11054], together with some cleanup. In particular:

  • XHTML doesn't allow multiple <thead> sections in a <table>.
  • Empty <body> are forbidden as well.
  • Put the <input> inside the <label>, allowing to remove the id= attribute, and with the advantage that clicking between the checkbox and the label will actually trigger the checkbox.

Thanks Oleg, your patch was an excellent starting point. I like the new layout very much.

comment:9 by Remy Blank, 12 years ago

Owner: changed from Remy Blank to Oleg Frantsuzov <franoleg@…>

comment:10 by Remy Blank, 12 years ago

Release Notes: modified (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Oleg Frantsuzov <franoleg@…>.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Oleg Frantsuzov <franoleg@…> to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.