Edgewall Software
Modify

Opened 15 years ago

Closed 15 years ago

Last modified 10 years ago

#8502 closed defect (fixed)

[Patch] trac-admin upgrade fails on postgresql databases that have capital letters in the schema

Reported by: bobbysmith007@… Owned by: bobbysmith007@…
Priority: normal Milestone: 0.11.6
Component: database backend Version: 0.11.5
Severity: major Keywords: patch, trac-admin, postgresql
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

This bug appears to be present in the trunk as well. Essentially if you have a schema like "TracName" in your trac connection string, then trac-admin <env> upgrade fails with an error about not finding the schema.

The solution is to wrap the schema name in double quotes.

I also found that the message from trac admin about bypassing backups (which also worked) was never being displayed because it was looking for the word "backup" in a string that contained the word "Backup".

Attached is a patch that should fix the two minor bugs.

Thanks for all the great work and dedication, trac is wonderful and makes my life better.

Attachments (2)

postgres_backup_fix.diff (1.5 KB ) - added by bobbysmith007@… 15 years ago.
Patch to fix two bugs about trac-admin upgrade failing on postgres
postgres_backup_fix.2.diff (1.1 KB ) - added by bobbysmith007@… 15 years ago.
Patch to fix two bugs about trac-admin upgrade failing on postgres (Without extra debugging info in teh error message)

Download all attachments as: .zip

Change History (6)

by bobbysmith007@…, 15 years ago

Attachment: postgres_backup_fix.diff added

Patch to fix two bugs about trac-admin upgrade failing on postgres

by bobbysmith007@…, 15 years ago

Attachment: postgres_backup_fix.2.diff added

Patch to fix two bugs about trac-admin upgrade failing on postgres (Without extra debugging info in teh error message)

comment:1 by Christian Boos, 15 years ago

Milestone: 0.11.6

Looks good.

comment:2 by Christian Boos, 15 years ago

Owner: set to bobbysmith007@…

Problem reproduced and fix confirmed to work - will be applied shortly.

comment:3 by Christian Boos, 15 years ago

Resolution: fixed
Status: newclosed

Patch applied in [8382]. Thanks!

comment:4 by Ryan J Ollos, 10 years ago

Keywords: postgresql added; postgres removed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain bobbysmith007@….
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from bobbysmith007@… to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.