ValueError: too many values to unpack

[jbergstroem]

How to Reproduce

While doing a GET operation on /timeline, Trac issued an internal error.

I've tried older versions of Genshi (r960 and some in between) with no positive outcome.

wiki_format_messages is set to false (after reading the other open ticket on the same subject). On first glance, this looks like a separate issue - therefore a new ticket. Please close if I'm wrong

User Agent was: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_5_7; en-us) AppleWebKit/531.0+ (KHTML, like Gecko) Version/4.0 Safari/530.17

System Information

Trac	0.12multirepos-r8257
Python	2.5.4 (r254:67916, May 12 2009, 15:08:47) [GCC 4.3.2]
setuptools	0.6c9
SQLite	3.6.12
pysqlite	2.3.2
Genshi	0.6dev-r1052
Babel	-
Pygments	1.0
Subversion	1.5.6 (r36142)
jQuery:	1.2.6

Python Traceback

Traceback (most recent call last):
  File "/usr/lib64/python2.5/site-packages/Trac-0.12multirepos_r8257-py2.5.egg/trac/web/main.py", line 464, in _dispatch_request
    dispatcher.dispatch(req)
  File "/usr/lib64/python2.5/site-packages/Trac-0.12multirepos_r8257-py2.5.egg/trac/web/main.py", line 234, in dispatch
    content_type)
  File "/usr/lib64/python2.5/site-packages/Trac-0.12multirepos_r8257-py2.5.egg/trac/web/chrome.py", line 802, in render_template
    stream.render(method, doctype=doctype, out=buffer)
  File "/usr/lib64/python2.5/site-packages/Genshi-0.6dev_r1052-py2.5-linux-x86_64.egg/genshi/core.py", line 183, in render
    return encode(generator, method=method, encoding=encoding, out=out)
  File "/usr/lib64/python2.5/site-packages/Genshi-0.6dev_r1052-py2.5-linux-x86_64.egg/genshi/output.py", line 57, in encode
    for chunk in iterator:
  File "/usr/lib64/python2.5/site-packages/Genshi-0.6dev_r1052-py2.5-linux-x86_64.egg/genshi/output.py", line 337, in __call__
    for kind, data, pos in stream:
  File "/usr/lib64/python2.5/site-packages/Genshi-0.6dev_r1052-py2.5-linux-x86_64.egg/genshi/output.py", line 823, in __call__
    for kind, data, pos in stream:
  File "/usr/lib64/python2.5/site-packages/Genshi-0.6dev_r1052-py2.5-linux-x86_64.egg/genshi/output.py", line 667, in __call__
    for kind, data, pos in stream:
  File "/usr/lib64/python2.5/site-packages/Genshi-0.6dev_r1052-py2.5-linux-x86_64.egg/genshi/output.py", line 768, in __call__
    for kind, data, pos in chain(stream, [(None, None, None)]):
  File "/usr/lib64/python2.5/site-packages/Genshi-0.6dev_r1052-py2.5-linux-x86_64.egg/genshi/output.py", line 583, in __call__
    for ev in stream:
  File "/usr/lib64/python2.5/site-packages/Genshi-0.6dev_r1052-py2.5-linux-x86_64.egg/genshi/core.py", line 288, in _ensure
    for event in stream:
  File "/usr/lib64/python2.5/site-packages/Genshi-0.6dev_r1052-py2.5-linux-x86_64.egg/genshi/core.py", line 288, in _ensure
    for event in stream:
  File "/usr/lib64/python2.5/site-packages/Trac-0.12multirepos_r8257-py2.5.egg/trac/web/chrome.py", line 875, in _strip_accesskeys
    for kind, data, pos in stream:
  File "/usr/lib64/python2.5/site-packages/Genshi-0.6dev_r1052-py2.5-linux-x86_64.egg/genshi/core.py", line 288, in _ensure
    for event in stream:
  File "/usr/lib64/python2.5/site-packages/Trac-0.12multirepos_r8257-py2.5.egg/trac/web/chrome.py", line 864, in _generate
    for kind, data, pos in stream:
  File "/usr/lib64/python2.5/site-packages/Genshi-0.6dev_r1052-py2.5-linux-x86_64.egg/genshi/core.py", line 288, in _ensure
    for event in stream:
  File "/usr/lib64/python2.5/site-packages/Genshi-0.6dev_r1052-py2.5-linux-x86_64.egg/genshi/template/base.py", line 588, in _include
    for event in stream:
  File "/usr/lib64/python2.5/site-packages/Genshi-0.6dev_r1052-py2.5-linux-x86_64.egg/genshi/template/markup.py", line 379, in _match
    ctxt, start=idx + 1, **vars):
  File "/usr/lib64/python2.5/site-packages/Genshi-0.6dev_r1052-py2.5-linux-x86_64.egg/genshi/template/markup.py", line 379, in _match
    ctxt, start=idx + 1, **vars):
  File "/usr/lib64/python2.5/site-packages/Genshi-0.6dev_r1052-py2.5-linux-x86_64.egg/genshi/template/markup.py", line 329, in _match
    for event in stream:
  File "/usr/lib64/python2.5/site-packages/Genshi-0.6dev_r1052-py2.5-linux-x86_64.egg/genshi/template/base.py", line 528, in _flatten
    for kind, data, pos in stream:
  File "/usr/lib64/python2.5/site-packages/Genshi-0.6dev_r1052-py2.5-linux-x86_64.egg/genshi/core.py", line 288, in _ensure
    for event in stream:
  File "/usr/lib64/python2.5/site-packages/Genshi-0.6dev_r1052-py2.5-linux-x86_64.egg/genshi/path.py", line 588, in _generate
    subevent = next()
  File "/usr/lib64/python2.5/site-packages/Genshi-0.6dev_r1052-py2.5-linux-x86_64.egg/genshi/template/base.py", line 588, in _include
    for event in stream:
  File "/usr/lib64/python2.5/site-packages/Genshi-0.6dev_r1052-py2.5-linux-x86_64.egg/genshi/template/markup.py", line 318, in _strip
    event = next()
  File "/usr/lib64/python2.5/site-packages/Genshi-0.6dev_r1052-py2.5-linux-x86_64.egg/genshi/template/base.py", line 528, in _flatten
    for kind, data, pos in stream:
  File "/usr/lib64/python2.5/site-packages/Genshi-0.6dev_r1052-py2.5-linux-x86_64.egg/genshi/core.py", line 288, in _ensure
    for event in stream:
  File "/usr/lib64/python2.5/site-packages/Genshi-0.6dev_r1052-py2.5-linux-x86_64.egg/genshi/path.py", line 588, in _generate
    subevent = next()
  File "/usr/lib64/python2.5/site-packages/Genshi-0.6dev_r1052-py2.5-linux-x86_64.egg/genshi/template/base.py", line 588, in _include
    for event in stream:
  File "/usr/lib64/python2.5/site-packages/Genshi-0.6dev_r1052-py2.5-linux-x86_64.egg/genshi/template/markup.py", line 318, in _strip
    event = next()
  File "/usr/lib64/python2.5/site-packages/Genshi-0.6dev_r1052-py2.5-linux-x86_64.egg/genshi/template/base.py", line 548, in _flatten
    result = _eval_expr(data, ctxt, vars)
  File "/usr/lib64/python2.5/site-packages/Genshi-0.6dev_r1052-py2.5-linux-x86_64.egg/genshi/template/base.py", line 277, in _eval_expr
    retval = expr.evaluate(ctxt)
  File "/usr/lib64/python2.5/site-packages/Genshi-0.6dev_r1052-py2.5-linux-x86_64.egg/genshi/template/eval.py", line 178, in evaluate
    return eval(self.code, _globals, {'__data__': data})
  File "/usr/lib64/python2.5/site-packages/Trac-0.12multirepos_r8257-py2.5.egg/trac/timeline/templates/timeline.html", line 48, in <Expression u"event.render('description', context)">
    ${event.render('description', context)}
  File "/usr/lib64/python2.5/site-packages/Trac-0.12multirepos_r8257-py2.5.egg/trac/timeline/web_ui.py", line 316, in <lambda>
    provider.render_timeline_event(context, field, event)
  File "/usr/lib64/python2.5/site-packages/Trac-0.12multirepos_r8257-py2.5.egg/trac/versioncontrol/web_ui/changeset.py", line 925, in render_timeline_event
    for c,r in changesets:
ValueError: too many values to unpack

[cboos]

Oops, good catch.

[cboos]

Fixed in r8267. Thanks for the report!

[jbergstroem]

Confirmed working, thanks for your (very) quick response!

[cboos]

The more embarrassing mistake, the fastest fix ;-)