Edgewall Software
Modify

Ticket #7974 (closed defect: duplicate)

Opened 3 years ago

Last modified 3 years ago

UnicodeDecodeError showing transplanted revision

Reported by: wbruna@… Owned by: cboos
Priority: normal Milestone:
Component: plugin/mercurial Version: 0.11
Severity: normal Keywords:
Cc:
Release Notes:
API Changes:

Description

Transplanted changesets include an extra field 'transplanted_source', containing the original changeset hash (as a 20-byte buffer). The content is returned as-is by the plugin, so it triggers an UnicodeDecodeError when rendering.

I'd suggest simply discarding unknown extra fields. IMHO, there isn't a good way to display these fields generically, since they don't carry type information. And they're usually interesting only to extensions, since they can't be created with a regular commit.

For transplant_source in particular, it would be nice showing a link to the transplanted revision - or simply its ID, if the original revision isn't available (could happen on transplants across branches).

Attachments

Change History

comment:1 in reply to: ↑ description ; follow-up: Changed 3 years ago by cboos

  • Resolution set to duplicate
  • Status changed from new to closed

Replying to wbruna@…:

...
For transplant_source in particular, it would be nice showing a link to the transplanted revision - or simply its ID, if the original revision isn't available (could happen on transplants across branches).

It already should do so, please upgrade :-) - see #7471.

comment:2 in reply to: ↑ 1 ; follow-ups: Changed 3 years ago by wbruna@…

Replying to cboos:

It already should do so, please upgrade :-) - see #7471.

Hum, somehow I missed it... probably searched only for the error message. Anyway, it's good to keep this ticket around, since Debian Lenny will ship version 0.11.

Thanks, and sorry for the noise!
Wagner

comment:3 in reply to: ↑ 2 Changed 3 years ago by wbruna@…

Replying to wbruna@…:

since Debian Lenny will ship version 0.11.

r7354, actually.

comment:4 in reply to: ↑ 2 Changed 3 years ago by cboos

Replying to wbruna@…:

... it's good to keep this ticket around, since Debian Lenny will ship version 0.11.

Thanks, this prompted me to update the TracMercurial page with a reference to the recent stable revisions (r7744 / r7757).

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
to The owner will be changed from cboos. Next status will be 'closed'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.