Reports that use URL parameters break when paginating

[domluc@…]

Some plugins (ie:TimingAndEstimationPlugin) add custom reports to trac and use aditional parameters, like:

http://example.com/trac/report/63?BILLABLE=1&UNBILLABLE=1&NOVO=novo&EMANDAMENTO=em_andamento&REABERTO=reaberto&RESOLVIDO=resolvido&FECHADO=fechado&TESTE=teste&ATRIBUIDO=atribuido&NEW=new&VERIFICADO=verificado&STARTDATE=0&ENDDATE=2000000000

that report on first load, works fine, but page '2' link breaks, pointing to

http://example.com/trac/report/63?page2

loosing URL query info, needed by report.

Plugin site: ​http://trac-hacks.org/wiki/TimingAndEstimationPlugin

[Emmanuel Blot]

About plugin, re-read NewTicket#Whentonotcreateatickethere

[Christian Boos]

No, I think it's a rightful one.

I haven't verified yet, but from the report it seems that extra request parameters are not part of the paging links, which could then break any report which expects extra report variabes.

[Christian Boos]

Easy to verify actually: report:14?PRIORITY=high → then click on a page link.

[domluc@…]

@eblot:you don't need to close a ticket just 'cause you're guessing that is invalid, read ticket before , not personally, but this way you will loose users contrib.

@cboos: perfect!

[Christian Boos]

well, well, you can't imagine how many such invalid reports we get, especially for the AccountManager plugin, so it's basically a reflex when we see it mentioned in a ticket, and I nearly did it myself as well ;-)

[domluc@…]

Replying to cboos:

well, well, you can't imagine how many such invalid reports we get, especially for the AccountManager plugin, so it's basically a reflex when we see it mentioned in a ticket, and I nearly did it myself as well ;-)

I understood, and really isn't personally with eblot.but let's leave this and focus on ticket :-). I'll try to make a patch next weekend, some tip in how i can get parameters like in query module?

[Christian Boos]

Would have loved to get a patch from you, but as I was looking at the code for providing the hints you asked for, I also saw the bug ;-)

trac/ticket/report.py

@@ -323 +323 @@
             shown_pages = paginator.get_shown_pages(21)
             for p in shown_pages:
                 pagedata.append([req.href.report(id, asc=asc, sort=sort_col,
-                                                 USER=user, page=p),
+                                                 page=p, **args),
                                  None, str(p), _('Page %(num)d', num=p)])
 
             fields = ['href', 'class', 'string', 'title']

So now you can help by testing it…

[domluc@…]

Ow..this is fast! I just apply this directly and works quite fine.

I tested with some plugins and native reports too.

[Christian Boos]

Ok, patch applied in r7346 (and sorry, I apparently have a bug in my commit script, as the message didn't get through).

[anonymous]

The applied patch works for paging, but it doesn't include changes for navigation arrows for previous and next. They don't work properly.

[Remy Blank]

Replying to anonymous:

The applied patch works for paging, but it doesn't include changes for navigation arrows for previous and next. They don't work properly.

Right, the same fix is needed for these links, as well as the query_href session parameter, otherwise the "Back to Query" link in the ticket view doesn't work either.

Fixed in [7476].