Edgewall Software
Modify

Ticket #7324 (closed defect: fixed)

Opened 4 years ago

Last modified 3 years ago

Firefox crashes when performing large quick search

Reported by: fermulator Owned by: rblank
Priority: normal Milestone: 0.11.3
Component: search system Version: 0.11b1
Severity: normal Keywords:
Cc: fermulator@…
Release Notes:
API Changes:

Description

Steps to reproduce issue:

  1. Using Firefox...
  2. Open a trac website.
  3. Provided we have a ticket (semi-large) with several comments (20+).
  4. Copy into the clipboard a sentence (15+ words) from a comment in said ticket.
  5. In the quick search of trac, paste that large sentence and perform the search. ... the results will be displayed ... probably only the ONE result of that ticket since the sentence would probably be unique.
  6. Click on the link to the ticket.

...

trac will cause firefox to use A LOT of CPU, and the ticket could take upwards of 2+ minutes to load. Yikes!

Sometimes even firefox will crash entirely ...

We suspect this has to do with syntax highlighting javascript from trac itself.

Comparison:

  1. Do a quicksearch for the TICKET NUMBER (i.e. #999)
  2. trac will automatically load the ticket, and it will be fast!

In the comparison case the only difference I can see is that there wouldn't be syntax highlighting ... ?

Attachments

search-limit.diff (630 bytes) - added by athomas 4 years ago.
Limit number of highlighted words on search

Download all attachments as: .zip

Change History

Changed 4 years ago by athomas

Limit number of highlighted words on search

comment:1 Changed 4 years ago by athomas

Give this patch a try.

comment:2 Changed 4 years ago by anonymous

What version of Firefox? I can't reproduce this in 2.0.0.14.

comment:3 Changed 3 years ago by rblank

  • Milestone set to 0.11.3
  • Owner changed from cboos to rblank

I can reproduce this issue in Firefox 2.0.0.17, for example using #31 and following the procedure provided in the ticket description. The browser never crashes, but I get the message box about "a script taking too long" several times before the page displays.

Limiting the number of highlights sounds like a good idea.

comment:4 Changed 3 years ago by rblank

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in [7695] by limiting highlighting to 10 terms, but also requiring terms to be at least 3 characters.

comment:5 Changed 3 years ago by anonymous

  • Owner changed from rblank to anonymous

iiourzoirhyzeoh zeo

comment:6 Changed 3 years ago by rblank

  • Owner changed from anonymous to rblank
View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
to The owner will be changed from rblank. Next status will be 'closed'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.