Edgewall Software

Ticket #7239 (closed defect: fixed)

Opened 14 months ago

Last modified 7 months ago

umask parameter is lost while instantiating _fcgi.WSGIServer

Reported by: screwdriver@… Owned by: rblank
Priority: normal Milestone: 0.11.3
Component: web frontend Version: 0.12dev
Severity: normal Keywords: fastcgi unix socket
Cc:

Description

umask parameter is not passed from trac.web._fcgi.WSGIServer class constructor to superclass' constructor, thus preventing user from setting sane umask value, which is important when listening on unix domain sockets.

Patch against today's trunk (r7063) attached.

Attachments

trac-7239.diff Download (0.5 KB) - added by screwdriver@… 14 months ago.
fix for the bug

Change History

Changed 14 months ago by screwdriver@…

fix for the bug

Changed 8 months ago by rblank

  • owner set to rblank
  • milestone set to 0.11.3

Indeed, this seems to be the case. No comment in the source about this being intentional, either.

I have never used FCGI and I don't have a server to test. Anybody volunteering to test the patch?

Changed 8 months ago by screwdriver@…

My trac box (three instances) runs with this patch fine since I've posted it.

Changed 7 months ago by rblank

  • status changed from new to closed
  • resolution set to fixed

Patch applied in [7758]. Thanks!

Add/Change #7239 (umask parameter is lost while instantiating _fcgi.WSGIServer)

Author


E-mail address and user name can be saved in the Preferences.


Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
to The owner will change from rblank. Next status will be 'closed'
 
Note: See TracTickets for help on using tickets.