Edgewall Software
Modify ↓

Ticket #7239 (closed defect: fixed)

Opened 4 years ago

Last modified 3 years ago

umask parameter is lost while instantiating _fcgi.WSGIServer

Reported by: screwdriver@… Owned by: rblank
Priority: normal Milestone: 0.11.3
Component: web frontend Version: 0.12dev
Severity: normal Keywords: fastcgi unix socket
Cc:
Release Notes:
API Changes:

Description

umask parameter is not passed from trac.web._fcgi.WSGIServer class constructor to superclass' constructor, thus preventing user from setting sane umask value, which is important when listening on unix domain sockets.

Patch against today's trunk (r7063) attached.

Attachments

trac-7239.diff​ (560 bytes) - added by screwdriver@… 4 years ago.
fix for the bug

Download all attachments as: .zip

Change History

Changed 4 years ago by screwdriver@…

fix for the bug

comment:1 Changed 3 years ago by rblank

  • Milestone set to 0.11.3
  • Owner set to rblank

Indeed, this seems to be the case. No comment in the source about this being intentional, either.

I have never used FCGI and I don't have a server to test. Anybody volunteering to test the patch?

comment:2 Changed 3 years ago by screwdriver@…

My trac box (three instances) runs with this patch fine since I've posted it.

comment:3 Changed 3 years ago by rblank

  • Resolution set to fixed
  • Status changed from new to closed

Patch applied in [7758]. Thanks!

View ↑

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
to The owner will be changed from rblank. Next status will be 'closed'
Author


E-mail address and user name can be saved in the Preferences.

Attachments ↑
 
Note: See TracTickets for help on using tickets.