Modify ↓
Ticket #7164 (closed defect: fixed)
Opened 4 years ago
Last modified 4 years ago
[PATCH] No alternate links should appear if no page or report exists
| Reported by: | Dave Gynn <dgynn@…> | Owned by: | cboos |
|---|---|---|---|
| Priority: | normal | Milestone: | 0.11.1 |
| Component: | wiki system | Version: | devel |
| Severity: | minor | Keywords: | |
| Cc: | |||
| Release Notes: | |||
| API Changes: | |||
Description
The altlinks for the content converters should not be added when a wiki page does not exist or when the user is looking at the available reports list. The attached patch checks for page.exists and id != -1 respectively.
Attachments
Change History
Changed 4 years ago by Dave Gynn <dgynn@…>
- Attachment altlinks-removed.diff added
comment:1 Changed 4 years ago by cboos
comment:2 Changed 4 years ago by Dave Gynn <dgynn@…>
I'm neutral on the reports list. The fact the report list is implemented as a report isn't relevant to the user. The report list page seems more like navigation than a report. Being able to get a CSV export of report titles seemed more like an unintended side-effect than a feature.
comment:3 Changed 4 years ago by cboos
- Component changed from general to wiki system
- Milestone set to 0.11.1
- Owner changed from jonas to cboos
- Severity changed from normal to minor
comment:4 Changed 4 years ago by cboos
- Resolution set to fixed
- Status changed from new to closed
Ok, fine, I've committed the full patch in r7396. Thanks!
Note: See
TracTickets for help on using
tickets.
Ok for the empty wiki page, but why for the report list? It's just the report of the reports, i.e. a report in itself and you might want to get it in other formats.