Edgewall Software

Ticket #7164 (closed defect: fixed)

Opened 5 months ago

Last modified 2 months ago

[PATCH] No alternate links should appear if no page or report exists

Reported by: Dave Gynn <dgynn@…> Owned by: cboos
Priority: normal Milestone: 0.11.1
Component: wiki system Version: devel
Severity: minor Keywords:
Cc:

Description

The altlinks for the content converters should not be added when a wiki page does not exist or when the user is looking at the available reports list. The attached patch checks for page.exists and id != -1 respectively.

Attachments

altlinks-removed.diff (2.0 kB) - added by Dave Gynn <dgynn@…> 5 months ago.

Change History

Changed 5 months ago by Dave Gynn <dgynn@…>

Changed 5 months ago by cboos

Ok for the empty wiki page, but why for the report list? It's just the report of the reports, i.e. a report in itself and you might want to get it in other formats.

Changed 5 months ago by Dave Gynn <dgynn@…>

I'm neutral on the reports list. The fact the report list is implemented as a report isn't relevant to the user. The report list page seems more like navigation than a report. Being able to get a CSV export of report titles seemed more like an unintended side-effect than a feature.

Changed 3 months ago by cboos

  • owner changed from jonas to cboos
  • component changed from general to wiki system
  • severity changed from normal to minor
  • milestone set to 0.11.1

Changed 2 months ago by cboos

  • status changed from new to closed
  • resolution set to fixed

Ok, fine, I've committed the full patch in r7396. Thanks!

Add/Change #7164 ([PATCH] No alternate links should appear if no page or report exists)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.