Ticket #7111 (closed defect: fixed)
Opened 4 years ago
Last modified 3 years ago
'checkbox' filter options are created as radio buttons a vise-versa
| Reported by: | carnold@… | Owned by: | rblank |
|---|---|---|---|
| Priority: | normal | Milestone: | 0.12 |
| Component: | web frontend | Version: | devel |
| Severity: | minor | Keywords: | query jquery javascript |
| Cc: | |||
| Release Notes: | |||
| API Changes: | |||
Description (last modified by thatch) (diff)
I was robbing some code and I stumbled upon some brokenness:
property.type == "checkbox" should be property.type == "radio"
Attachments
Change History
comment:1 Changed 4 years ago by thatch
- Description modified (diff)
- Milestone changed from 0.11.1 to 0.11
comment:2 Changed 4 years ago by cboos
Well, the whole query.js is dating and should be rewritten using jQuery.
comment:3 Changed 4 years ago by jruigrok
But that's also something that can be done for 0.11.1, yes?
It's not like it's a blocker issue or a must-need for 0.11.0's release.
comment:4 follow-up: ↓ 6 Changed 4 years ago by jruigrok
- Milestone changed from 0.11 to 0.11.1
The first issue has been fixed in the repository — postpone ticket to 0.11.1 for the jQuery rewrite, I think it would be too invasive at this point in the 0.11 release.
comment:5 Changed 4 years ago by jruigrok
- Milestone changed from 0.11.1 to 0.12
After talking with Jonas it would be better to put it for 0.12.
comment:6 in reply to: ↑ 4 Changed 4 years ago by cboos
comment:7 Changed 4 years ago by cboos
- Keywords query jquery javascript added
- Milestone changed from 0.13 to 0.12
- Owner set to cboos
comment:8 Changed 3 years ago by cboos
Note: for the refactoring of source:trunk/trac/htdocs/js/query.js@8534 to use jQuery, also take care of using the labels for the filters (see #3919).
comment:9 Changed 3 years ago by rblank
- Owner changed from cboos to rblank
I'll rewrite query.js using jQuery.
comment:10 follow-up: ↓ 12 Changed 3 years ago by rblank
Oh wow, that was painful. Very interesting, mind you , but painful!
Anyway, query.js has been rewritten using jQuery in [8603]. The only part I have left mostly unchanged is where the insertion point is determined. All solutions using jQuery that I have found were either longer and less clear, or grossly inefficient.
I have tested the new code with the following browsers, and all work well to the best of my knowledge:
- Firefox 3.0.14 (Linux)
- Opera 10.00 build 4585 (Linux)
- IE 7.0.5730.13 (Windows XP)
- Google Chrome 2.0.172.43 (Windows XP)
- Safari 4.0.3 (OS X 10.5.8)
Konqueror 3.5.10 fails, but that's a jQuery issue, so there's not much we can do about it.
I have certainly missed something, so some more testing using various browsers would be most welcome. In the meantime, I'll fix the translation of the field labels.
comment:11 Changed 3 years ago by rblank
- Resolution set to fixed
- Status changed from new to closed
The translation of ticket field labels has been fixed in [8604].
comment:12 in reply to: ↑ 10 Changed 3 years ago by anonymous
Replying to rblank:
Oh wow, that was painful. Very interesting, mind you , but painful!
Probably why this ticket was 17 months old :)
Thanks for the catch. It looks like the create* calls in there are also somewhat reversed.
The template code to compare against is source:trunk/trac/ticket/templates/query.html#L80