Edgewall Software
Modify

Ticket #6747 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

set_owner and set_resolution on a state change in a workflow result in poor formatting

Reported by: mark.m.mcmahon@… Owned by: jonas
Priority: low Milestone: 0.11
Component: ticket system Version: devel
Severity: minor Keywords:
Cc: mark.m.mcmahon@…
Release Notes:
API Changes:

Description

If you have both a set_resolution and a set_owner for a workflow item
e.g.

decline = open -> declined
decline.operations = set_owner,set_resolution
decline.set_owner = QA
decline.set_resolution = Next Release, Next Main Release, Not A Bug

then you get for the decline action...
"decline to QAas" (see image attached)

It was interesting to see that when I cut and pasted from the Browser that there was an extra space between "decline" and "to" (which is not noticable in the rendered page). Because of this the easiest fix would be to just add a space after "to %s" in default_workflow.py (patch attached).

(this was on 0.11dev-r6425)

Attachments

set_owner_and_set_resolution.PNG (5.9 KB) - added by mark.m.mcmahon@… 4 years ago.
Example of poor formatting
space_after_to.diff (2.1 KB) - added by mark.m.mcmahon@… 4 years ago.
patch to add a space after to %s

Download all attachments as: .zip

Change History

Changed 4 years ago by mark.m.mcmahon@…

Example of poor formatting

Changed 4 years ago by mark.m.mcmahon@…

patch to add a space after to %s

comment:1 Changed 4 years ago by ecarter

  • Resolution set to fixed
  • Status changed from new to closed

Testcase added to sandbox/testing in [6630].

Fixed in trunk in [6631] and in sandbox/testing in [6632].

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
to The owner will be changed from jonas. Next status will be 'closed'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.