Edgewall Software
Modify

Ticket #671 (closed defect: fixed)

Opened 8 years ago

Last modified 6 years ago

Resolved ticket in timeline displays wrong comment

Reported by: anonymous Owned by: cmlenz
Priority: high Milestone: 0.8
Component: timeline Version: devel
Severity: major Keywords:
Cc:
Release Notes:
API Changes:

Description

As observed on the current copy of trac running on this site, going to the timeline on 07/30/2004, #667 is resolved with a particular comment. The next entry is a resolution for #670, but displays the same comment from #667. This comment is not present in #670; in fact, the resolution has no comment at all.

Attachments

dup_ticket_message.patch (1.6 KB) - added by Matthew Good <matt-good.net> 8 years ago.
fix
dup_ticket_message.2.patch (735 bytes) - added by Matthew Good <matt-good.net> 8 years ago.
new patch since previous accidentally included an unrelated change

Download all attachments as: .zip

Change History

comment:1 Changed 8 years ago by cmlenz

  • Component changed from ticket system to timeline
  • Milestone set to 0.8
  • Priority changed from normal to high
  • Severity changed from normal to major

comment:2 Changed 8 years ago by Matthew Good <matt-good.net>

  • Owner changed from jonas to anonymous
  • Status changed from new to assigned

In ticket.cs a variable is used to prefix the comment with a hyphen to separate it from the resolution. This variable gets set if there is a comment, but never gets set back if there is no comment.

Uploading patch.

Changed 8 years ago by Matthew Good <matt-good.net>

fix

Changed 8 years ago by Matthew Good <matt-good.net>

new patch since previous accidentally included an unrelated change

comment:3 Changed 8 years ago by cmlenz

  • Owner changed from anonymous to cmlenz
  • Status changed from assigned to new

Hmm, shouldn't assign a ticket to anonymous.

comment:4 Changed 8 years ago by cmlenz

  • Status changed from new to assigned

comment:5 Changed 8 years ago by cmlenz

  • Resolution set to fixed
  • Status changed from assigned to closed

Thanks for the patch! I've appied it and checked it in [900].

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
to The owner will be changed from cmlenz. Next status will be 'closed'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.