Edgewall Software
Modify

Opened 16 years ago

Last modified 9 years ago

#6556 new defect

RSS feed is not valid

Reported by: nilcolor+trac@… Owned by:
Priority: low Milestone: unscheduled
Component: report system Version: 0.11b1
Severity: minor Keywords: rss netnewswire patch needfixup
Cc: lists@… Branch:
Release Notes:
API Changes:
Internal Changes:

Description

I have an Trac 0.11b1 installation and want to subscribe to RSS feed for tickets i need to monitor. But RSS feed is not visible within NetNewsWire Lite (v3.1b4). But its visible in Vienna (v.2.2.2.2212)… So i make a decicion that RSS feed have some "not-fatal" error within ('cause NNW is know as strict RSS reader) while Vienna allow and display this feed. I can't check feed with online validator - i have intraweb Trac so can't say exactly where is error is. Feed from this site is displayed well in NNW (i try this link http://trac.edgewall.org/report/20?format=rss&USER=anonymous)

Attachments (4)

Picture2.png (134.2 KB ) - added by nilcolor+trac@… 16 years ago.
Firefox and NetNewsWire Lite screenshot with report {1} as RSS
feeds.zip (2.5 KB ) - added by nilcolor+trac@… 16 years ago.
/query and /report/1 result feeds (archived)
report-6556.diff (3.5 KB ) - added by Emmanuel Blot 16 years ago.
Patch proposal to fix up invalid RSS report feed.
report-1-after-diff.rss.zip (1.8 KB ) - added by nilcolor+trac@… 16 years ago.
RSS file after applying patch

Download all attachments as: .zip

Change History (31)

comment:1 by Emmanuel Blot, 16 years ago

Keywords: rss needinfo added; RSS feed ticket report removed

Weird. I'm using NetNewsWire 3.0/1130 and I have no trouble getting feed from a Trac 0.11b1 server, neither from the changelog nor from the report view.

Report {20} is not part of the pristine Trac distribution. Which RSS URL is actually in trouble ?

by nilcolor+trac@…, 16 years ago

Attachment: Picture2.png added

Firefox and NetNewsWire Lite screenshot with report {1} as RSS

comment:2 by nilcolor+trac@…, 16 years ago

I try report {1} (All Tickets) as well as report {7} (My Tickets) - both didn't work within NNW and works with Vienna/Firefox And i try RSS feed from query like this http://portal/trac/tsm/query?status=accepted&status=assigned&status=new&reporter=nilcolor%40gmail.com&order=priority&col=id&col=summary&col=status&col=owner&col=type&col=priority&col=milestone That RSS is not working in NetNewsWire Lite 3.1b4 and its ask me to save .xml file if i paste that url in FireFox

in reply to:  2 comment:3 by Emmanuel Blot, 16 years ago

Replying to nilcolor+trac@gmail.com: http://portal/trac/tsm/query?status=accepted&status=assigned...

This is not a valid RSS feed URL: Trac RSS feed URL always contains a "format=rss" parameter. Please double-check this URL.

I copied 'n pasted your URL with a local installation, added the "format=rss" parameter, and obtained a feed that NetNewsWire has been able to read with no trouble. So either your URL is wrong or some of the cyrillic characters are causing some trouble.

Please retrieve the content of an invalid RSS feed with wget and attach it to this ticket. Use the --save-headers option switches so that the attached file contains all the HTTP headers.

comment:4 by anonymous, 16 years ago

Sorry, i didn't have wget - and i download feer with next commands:

curl --include "http://itportal/trac/tsm/report/1?format=rss&USER=anonymous" --ou
tput report-1.rss

and

curl --include "http://itportal/trac/tsm/query?status=accepted&status=assigned&st
atus=new&format=rss&order=priority" --output query-1.rss

Both files attached…

by nilcolor+trac@…, 16 years ago

Attachment: feeds.zip added

/query and /report/1 result feeds (archived)

comment:5 by Emmanuel Blot, 16 years ago

The RSS you've attached is not valid. One issue is already known (multiple pubDate), the other issues may need some fixing. Stay tuned…

comment:6 by Emmanuel Blot, 16 years ago

Owner: changed from Matthew Good to Emmanuel Blot
Status: newassigned

by Emmanuel Blot, 16 years ago

Attachment: report-6556.diff added

Patch proposal to fix up invalid RSS report feed.

comment:7 by Emmanuel Blot, 16 years ago

Could you try the attached patch file (report-6556.diff) and check if the report RSS feed works for you? Note that this patch does not address query feeds, only report feeds.

comment:8 by osimons, 16 years ago

I haven't reveiwed or tested the patch, but just spotted that you used this to get the logo url:

chrome.logo.src_abs and chrome.logo.src_abs or abs_href(chrome.logo.src)

It won't work. If logo url is http://... it will print 'True' in the template - useful :-) If it is a regular project reference, it already gets calculated inside trac.web.chrome.Chrome.get_logo_data() so what you then abs_href() is already href()'ed - meaning the path to the project gets duplicated (like http://.../trac/project/trac/project/chrome/...).

I added a ticket for this (see #6562) - it would be OK if you could use the opportunity to see how that works with your rss modifications. A second opinion would be very useful. Until that gets committed, the best alternative is just sticking to the single line with <url>$chrome.logo.src</url>. I'll hopefully update that to something better soon.

in reply to:  7 ; comment:9 by anonymous, 16 years ago

Replying to eblot:

Could you try the attached patch file (report-6556.diff) and check if the report RSS feed works for you? Note that this patch does not address query feeds, only report feeds.

i apply .diff file and restart webserver (Apache). But NetNewsWire still didn't show anything. New feed file attached.

by nilcolor+trac@…, 16 years ago

Attachment: report-1-after-diff.rss.zip added

RSS file after applying patch

in reply to:  9 ; comment:10 by Emmanuel Blot, 16 years ago

Replying to anonymous:

i apply .diff file and restart webserver (Apache). But NetNewsWire still didn't show anything. New feed file attached.

Well, the W3C RSS feed validator reports: "This is a valid RSS feed." with your latest attachement, so at least the feed is valid. Can you check whether the error window in NNW reports any useful information?

in reply to:  8 comment:11 by Emmanuel Blot, 16 years ago

Replying to osimons:

It won't work. If logo url is http://... it will print 'True' in the template - useful :-) If it is a regular project reference, it already gets calculated inside trac.web.chrome.Chrome.get_logo_data() so what you then abs_href() is already href()'ed - meaning the path to the project gets duplicated (like http://.../trac/project/trac/project/chrome/...).

I did not check how these routines behave in details, so I've probably missed an important point here. The trouble is that the URL produced with <url>$chrome.logo.src</url> is invalid as it contains only the server part, which is not valid for feeds (contrarily to HTML pages). I'll try your proposal (#6652) and report the result back. Thanks for the hint.

in reply to:  10 ; comment:12 by anonymous, 16 years ago

Replying to eblot:

Well, the W3C RSS feed validator reports: "This is a valid RSS feed." with your latest attachement, so at least the feed is valid. Can you check whether the error window in NNW reports any useful information?

It works now… Really. Maybe it was some sort of cache problem but now NNM Lite shows me tickets. Thanks for fix. And thanks for Trac!

in reply to:  12 ; comment:13 by Emmanuel Blot, 16 years ago

Replying to anonymous:

It works now… Really. Maybe it was some sort of cache problem but now NNM Lite shows me tickets. Thanks for fix. And thanks for Trac!

As osimons reported, the fix introduces a regression with the logo URL and needs to be fixed. At least the other issues seem to have been addressed. Can you verify the news date are valid - i.e. matches the one in your reports?

in reply to:  13 comment:14 by nilcolor+trac@…, 16 years ago

Replying to eblot:

As osimons reported, the fix introduces a regression with the logo URL and needs to be fixed. At least the other issues seem to have been addressed. Can you verify the news date are valid - i.e. matches the one in your reports?

It seems that dates is OK. One example. I create one ticket and:

  • Trac tell me that it was created 2007-12-28T16:34:22Z+0300
  • Within RSS file its <pubDate>Fri, 28 Dec 2007 13:34:22 GMT</pubDate>
  • And NNW shows me 28/12/07 16:34

So its seems that date is OK. I live in Russia, Moscow and my timezone GMT+3

comment:15 by osimons, 16 years ago

Milestone: 0.11

Chatted with eblot, and we decided to bump the priority on this - valid RSS feeds should be 0.11.

comment:16 by nilcolor+trac@…, 16 years ago

Nice to hear. Will wait for 0.11. And thanks for help!

comment:17 by Christian Boos, 16 years ago

I didn't notice the patch at first. attachment:report-6556.diff looks good to me, could you please apply it manu if this actually fixes the issue?

comment:18 by nilcolor+trac@…, 16 years ago

Keywords: netnewswire added

Hm.. Just upgraded to Leopard (not sure it means something but…) and install fresh copy of NNW (its free now BTW). And Active Ticket RSS stop working again.

  • Online RSS verificator says its OK. (One warning though)
  • NNW Error log shows nothing
  • But feed is empty (i have active tickets - i'm sure) and market gray within NNW
  • Safari/Vienna show feed OK. NNW - not.

comment:19 by Christian Boos, 16 years ago

Milestone: 0.11.20.11.3
Priority: normallow
Severity: normalminor

comment:20 by Remy Blank, 15 years ago

Keywords: needinfo removed

comment:21 by Thijs Triemstra <lists@…>, 14 years ago

Works fine with NNW 3.27 on Leopard 10.5.8 for http://trac.edgewall.org/report/20?format=rss&USER=anonymous here.

comment:22 by Thijs Triemstra <lists@…>, 14 years ago

The RSS validator reports 2 warnings:

  • line 17, column 29: Image title doesn't match channel title
  • line 125, column 2: Missing atom:link with rel="self"

Perhaps this ticket can be about fixing those.

comment:23 by Thijs Triemstra <lists@…>, 14 years ago

Cc: lists@… added
Keywords: patch added

Here's a patch that should fix the first warning:

  • trac/ticket/templates/report_list.rss

     
    88    <description>List of available reports</description>
    99    <language>en-us</language>
    1010    <image py:if="chrome.logo.src_abs">
    11       <title>$project.name</title>
     11      <title>$project.name: Available Reports</title>
    1212      <url>$chrome.logo.src_abs</url>
    1313      <link>${abs_href.report()}</link>
    1414    </image>

comment:24 by Christian Boos, 14 years ago

No, the channel title is different for each report (here you were just testing the list of all available reports, which is itself a report).

comment:25 by Christian Boos, 14 years ago

Keywords: needfixup added

comment:26 by Christian Boos, 13 years ago

Milestone: next-minor-0.12.xunscheduled

Any chance for an updated patch? "Unschedul'ing" for now.

comment:27 by Ryan J Ollos, 9 years ago

Owner: Emmanuel Blot removed
Status: assignednew

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.
The ticket will be disowned.
as The resolution will be set. Next status will be 'closed'.
The owner will be changed from (none) to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.