Edgewall Software

Ticket #6438 (closed enhancement: fixed)

Opened 12 months ago

Last modified 12 months ago

max attachment filesize info in upload form

Reported by: anonymous Owned by: osimons
Priority: normal Milestone: 0.11
Component: attachment Version: devel
Severity: minor Keywords:
Cc:

Description

would be nice to see a hint in the attachment upload form, where you can see the max filesize for attachments.. this info is also usefull for the users

Attachments

t6438-r6280-attachment_max_size.diff (1.3 KB) - added by osimons 12 months ago.
Patch with information on max size for uploads.
t6438-r6280-attachment_max_size-b.diff (1.3 KB) - added by osimons 12 months ago.
Forgot that it can be set to '0' (zero) for unlimited. No point in displaying it then.
t6438-r6280-attachment_max_size-c.diff (1.8 KB) - added by cboos 12 months ago.
Another version, with the message in the template

Change History

Changed 12 months ago by osimons

Patch with information on max size for uploads.

follow-up: ↓ 2   Changed 12 months ago by osimons

  • owner changed from jonas to osimons
  • version set to devel
  • component changed from general to attachment
  • severity changed from normal to minor
  • milestone set to 0.11.1

Good idea. Attached a patch that instead of 'File:' renders 'File (max. 256 kb):' (or whatever the current max is).

Feedback? Commit?

Changed 12 months ago by osimons

Forgot that it can be set to '0' (zero) for unlimited. No point in displaying it then.

in reply to: ↑ 1   Changed 12 months ago by eblot

Replying to osimons:

Good idea. Attached a patch that instead of 'File:' renders 'File (max. 256 kb):' (or whatever the current max is). Feedback? Commit?

+1, although the pretty_size() function could be revisited a little bit to remove useless data - maybe at a later time.
Example:

File (256.0 kB):

256 kB would look more natural.

Changed 12 months ago by cboos

Another version, with the message in the template

  Changed 12 months ago by cboos

I attached an updated version of the patch, with the pretty_size() variation and also putting the message directly in the template, which I think should be preferred whenever possible.

Ok for 0.11.

  Changed 12 months ago by osimons

  • status changed from new to closed
  • resolution set to fixed
  • milestone changed from 0.11.1 to 0.11

Last patch from cboos committed as [6286]. Only changed the text a little to make it less obtrusive - now just says 'size limit'.

Add/Change #6438 (max attachment filesize info in upload form)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
to The owner will change from osimons. Next status will be 'closed'
 
Note: See TracTickets for help on using tickets.