Edgewall Software
Modify

Opened 16 years ago

Closed 16 years ago

#6438 closed enhancement (fixed)

max attachment filesize info in upload form

Reported by: anonymous Owned by: osimons
Priority: normal Milestone: 0.11
Component: attachment Version: devel
Severity: minor Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

would be nice to see a hint in the attachment upload form, where you can see the max filesize for attachments.. this info is also usefull for the users

Attachments (3)

t6438-r6280-attachment_max_size.diff (1.3 KB ) - added by osimons 16 years ago.
Patch with information on max size for uploads.
t6438-r6280-attachment_max_size-b.diff (1.3 KB ) - added by osimons 16 years ago.
Forgot that it can be set to '0' (zero) for unlimited. No point in displaying it then.
t6438-r6280-attachment_max_size-c.diff (1.8 KB ) - added by Christian Boos 16 years ago.
Another version, with the message in the template

Download all attachments as: .zip

Change History (7)

by osimons, 16 years ago

Patch with information on max size for uploads.

comment:1 by osimons, 16 years ago

Component: generalattachment
Milestone: 0.11.1
Owner: changed from Jonas Borgström to osimons
Severity: normalminor
Version: devel

Good idea. Attached a patch that instead of 'File:' renders 'File (max. 256 kb):' (or whatever the current max is).

Feedback? Commit?

by osimons, 16 years ago

Forgot that it can be set to '0' (zero) for unlimited. No point in displaying it then.

in reply to:  1 comment:2 by Emmanuel Blot, 16 years ago

Replying to osimons:

Good idea. Attached a patch that instead of 'File:' renders 'File (max. 256 kb):' (or whatever the current max is).

Feedback? Commit?

+1, although the pretty_size() function could be revisited a little bit to remove useless data - maybe at a later time.
Example:

File (256.0 kB):

256 kB would look more natural.

by Christian Boos, 16 years ago

Another version, with the message in the template

comment:3 by Christian Boos, 16 years ago

I attached an updated version of the patch, with the pretty_size() variation and also putting the message directly in the template, which I think should be preferred whenever possible.

Ok for 0.11.

comment:4 by osimons, 16 years ago

Milestone: 0.11.10.11
Resolution: fixed
Status: newclosed

Last patch from cboos committed as [6286]. Only changed the text a little to make it less obtrusive - now just says 'size limit'.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain osimons.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from osimons to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.