Modify ↓
Ticket #6433 (closed defect: fixed)
Opened 4 years ago
Last modified 17 months ago
SpamFilter has no input validation on Configuration screen in webadmin
| Reported by: | datakid@… | Owned by: | |
|---|---|---|---|
| Priority: | low | Milestone: | plugin - spam-filter |
| Component: | plugin/spamfilter | Version: | 0.10.4 |
| Severity: | major | Keywords: | spamfilter karma validation |
| Cc: | |||
| Release Notes: | |||
| API Changes: | |||
Description (last modified by cboos) (diff)
One of my trac admins changed the Minimum Karma level to "0.5" (ie a half) and now we cannot get back to the configuration screen at http://trac.site.com/admin/spamfilter/config .
The error thrown is:
Internal Error expected integer, got u'0.5'
On trac v 0.10.4 and TracSpamFilter? 0.2.1dev-r5943
Attachments
Change History
comment:1 Changed 4 years ago by cboos
- Milestone set to not applicable
- Priority changed from normal to low
comment:2 Changed 3 years ago by anonymous
comment:3 Changed 2 years ago by cboos
- Description modified (diff)
- Milestone changed from not applicable to spam-filter-plugin
- Owner mgood deleted
comment:4 Changed 17 months ago by dstoecker
- Resolution set to fixed
- Status changed from new to closed
comment:5 Changed 17 months ago by rblank
Could you please add a link to the changeset that fixed this issue?
comment:6 Changed 17 months ago by dstoecker
I don't know. Was long before my time. I tested it and it works correctly and the code says the same.
Note: See
TracTickets for help on using
tickets.
With the ini-admin plugin, you cound go to the URL "/admin/tracini/spam-filter" and change the "min_karma" setting there (or search for it in your trac.ini and edit it there).
Nevertheless, if an integer is expected, the plugin should not let anything but an integer through - i.e. that wrong value should not have been saved.