action "accept" in a ticket visited by owner

[decipher@…]

the action "accept" appear when a ticket is visited by owner. If it is selected it does nothing

Attach patch for not option display

[cboos]

If it is selected it does nothing

I think this is rather the problem, not the fact that the "accept" action gets listed.

What is the status of the ticket which exhibits the issue and which workflow are you using?

[anonymous]

Replying to cboos:

I think this is rather the problem, not the fact that the "accept" action gets listed.

What is the status of the ticket which exhibits the issue and which workflow are you using?

• The status of the ticket is accepted

• I'm using the workflow

  [ticket]
  default_component =
  default_milestone =
  default_priority = major
  default_type = defect
  default_version =
  max_description_size = 262144
  restrict_owner = false
  workflow = ConfigurableTicketWorkflow
  
  [ticket-workflow]
  accept = new,assigned,accepted,reopened -> accepted
  accept.operations = set_owner_to_self
  accept.permissions = TICKET_MODIFY
  leave = * -> *
  leave.default = 1
  leave.operations = leave_status
  reassign = new,assigned,accepted,reopened -> assigned
  reassign.operations = set_owner
  reassign.permissions = TICKET_MODIFY
  reopen = closed -> reopened
  reopen.operations = del_resolution
  reopen.permissions = TICKET_CREATE
  resolve = new,assigned,accepted,reopened -> closed
  resolve.operations = set_resolution
  resolve.permissions = TICKET_MODIFY
  

[cboos]

Replying to anonymous:

Replying to cboos:

I think this is rather the problem, not the fact that the "accept" action gets listed.

What is the status of the ticket which exhibits the issue and which workflow are you using?

• The status of the ticket is accepted

• I'm using the workflow

...
accept = new,assigned,accepted,reopened -> accepted

Ok, I see. I suppose you have the above spec because you'd like to have the ability to shortcut the following sequence: ... --[assign to yourself]--> assigned --[accept]--> accepted

See also #2045.

[ecarter]

The patch suggested hardcodes behavior for the 'assigned' state; we can't use that approach.

To make this work properly, the workflow system would have to recognize that an action would result in no changes to the ticket, and have no side-effects.

[jlove]

This can be fixed by using the plugin ​VirtualTicketPermissionsPlugin with the modification from jlove to add the permission TICKET_IS_NOTOWNER.

For example:

accept.permissions = TICKET_IS_NOTOWNER

[cboos]

Replying to ecarter:

To make this work properly, the workflow system would have to recognize that an action would result in no changes to the ticket, and have no side-effects.

I guess that's not easily doable for the side-effects part. Suggesting a wontfix - as there are workarounds.