Edgewall Software

Ticket #582 (closed defect: fixed)

Opened 4 years ago

Last modified 3 years ago

wiki formatting problem: tables are not indented

Reported by: vittorio Owned by: athomas
Priority: normal Milestone: 0.10
Component: wiki system Version: devel
Severity: normal Keywords: table
Cc: vittorio@…

Description

tables arent indented when starting the lines with a few spaces. for example:

  ||A||B||

    ||C||D||
AB
CD

following html code is generated:

<blockquote>
</blockquote>
<table class="wiki">
<tr></td></tr></table>

<p>
<td>A</td><td>B
</p>
<blockquote>
<blockquote>
</blockquote>
</blockquote>
<table class="wiki">
<tr></td></tr></table>
<p>
<td>C</td><td>D
</p>

using trunk r790

Attachments

indented-tables.diff (2.5 KB) - added by athomas 3 years ago.
Patch against r3234 with minor fix for paragraph breaks

Change History

Changed 4 years ago by jonas

  • status changed from new to assigned

Changed 4 years ago by jonas

  • milestone changed from 0.8 to 0.9

Changed 4 years ago by anonymous

  • status changed from assigned to closed
  • resolution set to fixed

Changed 4 years ago by cboos

  • status changed from closed to reopened
  • resolution fixed deleted

Please, don't close a bug without a comment stating why you closed it.

By the way, the generated HTML with the current trunk is still the same as the one reported, so the problem (if there is a problem) remains.

Changed 3 years ago by vittorio

  • cc vittorio@… added

Changed 3 years ago by cmlenz

  • milestone changed from 0.9 to 0.9.1

Postponing again.

Changed 3 years ago by cmlenz

  • milestone changed from 0.9.1 to 0.9.2

And again.

Changed 3 years ago by cmlenz

  • milestone changed from 0.9.3 to 1.0

And again.

Changed 3 years ago by cmlenz

  • milestone changed from 1.0 to 0.10

Changed 3 years ago by athomas

Seems to work, all unit tests pass.

Changed 3 years ago by athomas

Patch against r3234 with minor fix for paragraph breaks

Changed 3 years ago by athomas

  • owner changed from jonas to athomas
  • status changed from reopened to new

Changed 3 years ago by cboos

  • keywords table added

Alec, I've tested the patch and it works well. I think you can commit it.

Changed 3 years ago by athomas

I found a bug unfortunately :( If tables are separated by newlines I can make it work, but if they are like this:

||a||
  ||b||
||c||

The third table is joined with the second. Anyway, I'll keep playing until I figure it out :)

Changed 3 years ago by cboos

Yes, I've seen that too, but it didn't bothered me that much: it's something that the user can easily "fix" by adding an extra newline, whereas the other problems your patch fixes can't be fixed by the user. So I think that applying the patch and keeping note of the above issue is better that leaving the issue open waiting for the "perfect" fix (which will only be perfect until someone find another edge case anyway :) ).

Changed 3 years ago by athomas

  • status changed from new to closed
  • resolution set to fixed

Okay, I think I've hit a good compromise in r3261. Indented tables work 100% correctly, except that rows can no longer be separated by blank lines.

Add/Change #582 (wiki formatting problem: tables are not indented)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
to The owner will change from athomas. Next status will be 'closed'
 
Note: See TracTickets for help on using tickets.