Incorrect resolution of links to pages in htdocs

[anonymous]

I'm trying to point to a particular section of a static page in htdocs

[htdocs:manual.html#installation Installation]

the manual.html page is correctly open but the installation section is not showed as expected (firefox 2.0).

The url generated by trac is

http://localhost:8000/myproject/chrome/site/manual.html%23installation

I didn't find any way to quote the # character andprevent it to be translated in %23

[osimons]

This should fix it - based on the strategy used in other link resolvers:

trac/web/chrome.py

@@ -386 +386 @@
         yield ('htdocs', self._format_link)
 
     def _format_link(self, formatter, ns, file, label):
-        return tag.a(label, href=formatter.href.chrome('site', file))
+        file, query, fragment = formatter.split_link(file)
+        href = formatter.href.chrome('site', file) + query + fragment
+        return tag.a(label, href=href)
 
     # Public API methods

I don't think this change will have other effects than making such links actually work, so I'll commit unless objections are voiced.

[osimons]

Patch committed as [6502].