Ticket #5497 (closed defect: fixed)
Opened 5 years ago
Last modified 4 years ago
Component owner should not override assigned owner
| Reported by: | eblot | Owned by: | ecarter |
|---|---|---|---|
| Priority: | normal | Milestone: | 0.11 |
| Component: | ticket system | Version: | devel |
| Severity: | normal | Keywords: | workflow |
| Cc: | |||
| Release Notes: | |||
| API Changes: | |||
Description
When the following actions are performed (at once) on an open ticket, using the default workflow:
- Change the component, and
- Re-assign to a new owner
the resulting ticket is assigned to the component default owner, not to the owner specified in the "Assign to" dropbox.
Attachments
Change History
comment:1 Changed 5 years ago by eblot
- Keywords workflow added
- Owner changed from jonas to ecarter
comment:2 Changed 5 years ago by ecarter
- Status changed from new to assigned
comment:3 Changed 5 years ago by ecarter
- Milestone set to 0.11
comment:4 Changed 5 years ago by ecarter
comment:5 follow-up: ↓ 6 Changed 5 years ago by ThurnerRupert
here its more the other way round ... if you change the component, the owner does not change at all. what should it be?
comment:6 in reply to: ↑ 5 Changed 5 years ago by ecarter
Replying to ThurnerRupert:
here its more the other way round ... if you change the component, the owner does not change at all. what should it be?
That should be covered in the referenced testcase; the owner should change to the component owner, as I understand it.
comment:7 Changed 4 years ago by ThurnerRupert
could this go to 0.11.1?
comment:8 Changed 4 years ago by eblot
On retracile's request, here are the result of the test sessions I ran with the sandbox/testing branch
Working copy
URL: http://svn.edgewall.com/repos/trac/sandbox/testing
Revision: 5916
Mac OS X
Mac OS X 10.4.9 {Genshi 0.4.1, 0.4.3, 0.4.4} x { Python 2.4, 2.5}
amazas:~/Sources/Svn/edgewall.org/trac/sandbox/testing eblot$
PYTHONPATH=`pwd`:~/Sources/Svn/edgewall.org/genshi/tags/0.4.1 python2.4 trac/test.py
======================================================================
FAIL: Test for regression of http://trac.edgewall.org/ticket/5497
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/eblot/Sources/Svn/edgewall.org/trac/sandbox/testing/trac/tests/functional.py", line 823, in runTest
tc.find(regex_owned_by('user'))
File "/Library/Frameworks/Python.framework/Versions/2.4/lib/python2.4/site-packages/twill-0.9b1-py2.4.egg/twill/commands.py", line 230, in find
raise TwillAssertionError("no match to '%s'" % (what,))
TwillAssertionError: no match to '<_sre.SRE_Pattern object at 0x22a54a0>'
----------------------------------------------------------------------
Ran 710 tests in 165.138s
FAILED (failures=1)
Linux
Linux Debian/unstable 2.6.21-2-686 Genshi 0.4.3-1 Python 2.4
18 similar failures
eblot@vamazas:~/trac/testing$
PYTHONPATH=`pwd` python2.4 trac/test.py
======================================================================
FAIL: Set preferences for admin user
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/eblot/trac/testing/trac/tests/functional.py", line 647, in runTest
tc.formvalue('prefs', 'name', 'System Administrator')
File "/home/eblot/trac/testing/trac/tests/functional.py", line 146, in better_formvalue
raise twill.errors.TwillAssertionError(*args)
TwillAssertionError: ('no matching forms!', '<!DOCTYPE html ...
See r5616.log.bz2 for the complete log
Note that although 18 tests fail, a tracd session with either a new Trac
environment or the testenv888 environment generated by the test session work
fine from a web browser perspective: no visible issue.
comment:9 follow-up: ↓ 10 Changed 4 years ago by ThurnerRupert
- Milestone changed from 0.11 to 0.11.1
according to eblot no visible issue, so it seems to block 0.11 unecessarily ...
comment:10 in reply to: ↑ 9 Changed 4 years ago by eblot
Replying to ThurnerRupert:
according to eblot no visible issue, so it seems to block 0.11 unecessarily ...
No, my comment was about the sandbox/testing tests, not about the primary issue.
comment:11 follow-up: ↓ 12 Changed 4 years ago by ecarter
Tim noticed that OS/X has tidy installed and twill uses it if available. It looks like the failures in the sandbox/testing branch were due to tidy. As of [6609], tidy is disabled and no longer causes test failures on OS/X.
At this point, I believe this bug is fixed. eblot, can you verify that?
comment:12 in reply to: ↑ 11 Changed 4 years ago by eblot
Replying to ecarter:
At this point, I believe this bug is fixed. eblot, can you verify that?
Works fine:
$> svn info . URL: http://svn.edgewall.org/repos/trac/sandbox/testing Revision: 6612
- w/o twill
$> PYTHONPATH=$PWD python2.5 trac/test.py SKIP: functional tests (no twill installed) ... Ran 714 tests in 24.782s OK
- w/ twill installed
$> PYTHONPATH=$PWD python2.5 trac/test.py ...Ran 755 tests in 166.582s OK
although since the original comments, I've upgraded from Tiger to Leopard, so Python version has been bumped to 2.5.
comment:13 Changed 4 years ago by ecarter
- Resolution set to fixed
- Status changed from assigned to closed
comment:14 Changed 4 years ago by cboos
- Milestone changed from 0.11.1 to 0.11
Hrm. I can't reproduce this on sandbox/testing. I've added a test case for it; look for !RegressionTestTicket5497 in sandbox/testing/trac/tests/functional.py
Can you look at that and see if I missed something?