Modify ↓
Ticket #5402 (closed enhancement: wontfix)
allow : in the trac post-commit svn hook
| Reported by: | anarcat | Owned by: | eblot |
|---|---|---|---|
| Priority: | low | Milestone: | |
| Component: | general | Version: | 0.10.3 |
| Severity: | trivial | Keywords: | |
| Cc: | anarcat@… |
Description
We changed a bit the regex for the trac hook here to allow "Closes: #000" syntax, as it is natural to some of us.
Here is the diff on the trunk hook:
--- trac-post-commit-hook.1 2007-05-31 18:27:40.000000000 -0400
+++ trac-post-commit-hook 2007-05-31 18:27:50.000000000 -0400
@@ -112,7 +112,7 @@
ticket_prefix = '(?:#|(?:ticket|issue|bug)[: ]?)'
ticket_reference = ticket_prefix + '[0-9]+'
-ticket_command = (r'(?P<action>[A-Za-z]*).?'
+ticket_command = (r'(?P<action>[A-Za-z]*):?.?'
'(?P<ticket>%s(?:(?:[, &]*|[ ]?and[ ]?)%s)*)' %
(ticket_reference, ticket_reference))
Trivial, really. :)
Attachments
Change History
Note: See
TracTickets for help on using
tickets.



Thanks for the patch.
However, commit hook scripts are provided as an example of better integration of Trac and SVN, and are expected to be customized to fit a team needs.
I'm closing this ticket as I don't think it is worth applying it to the default commit hook script, however it's still searchable for other users that look for hook script modifications and might find it useful.