Ticket #4964 (closed enhancement: duplicate)
Opened 5 years ago
Last modified 5 years ago
User filter for timeline
| Reported by: | yotamrubin@… | Owned by: | cboos |
|---|---|---|---|
| Priority: | low | Milestone: | |
| Component: | timeline | Version: | 0.10.3.1 |
| Severity: | minor | Keywords: | user |
| Cc: | |||
| Release Notes: | |||
| API Changes: | |||
Description
Hello there,
I've just added the capability to filter the timeline by username. The change should have been trivial, but apparently the Timeline is rather difficult to get into. The process_request function is quite large, and has a very complex namespace. I did some dumb refactoring - moved out logical blocks in process_request to their own functions, but the logic remains the same. Additionally, the way I added the user filter is rather ad-hoc, since the current filter mechanism is a boolean one, either it's enabled, or not. Maybe next weekend I'll work on improving the filter mechanism.
Attachments
Change History
Changed 5 years ago by yotamrubin@…
- Attachment trac-with-userfilter.diff added
comment:1 follow-up: ↓ 3 Changed 5 years ago by cboos
- Keywords user added
Ouch, sorry, but this is never going to make it into Trac, as development of the 0.10-stable branch is for bug fixes only.
The trunk (Trac 0.11dev) is in heavy development since months, and the timeline module has changed a lot, though your points would still be valid with the new version of the code, see source:trunk/trac/timeline/web_ui.py. Look also at the new approach we started in e.g. r4970 for handling requests.
So it would be very much appreciated if you reworked your patch for the trunk. Also, be aware that the web templates are quite different now: see TracDev/PortingFromClearSilverToGenshi.
comment:2 Changed 5 years ago by cboos
- Milestone 0.11 deleted
- Resolution set to duplicate
- Status changed from new to closed
As #1198 was the original feature request, with already many people CC'ed there, I'm closing this one as duplicate.
comment:3 in reply to: ↑ 1 Changed 5 years ago by anonymous
Ok then. I've looked at the development version of trac. Seems like basic issues mentioned in my ticket appear in that version as well. I'll adapt my patch to the development version, and maybe resolve the filter issue as well.
Replying to cboos:
Ouch, sorry, but this is never going to make it into Trac, as development of the 0.10-stable branch is for bug fixes only.
The trunk (Trac 0.11dev) is in heavy development since months, and the timeline module has changed a lot, though your points would still be valid with the new version of the code, see source:trunk/trac/timeline/web_ui.py. Look also at the new approach we started in e.g. r4970 for handling requests.
So it would be very much appreciated if you reworked your patch for the trunk. Also, be aware that the web templates are quite different now: see TracDev/PortingFromClearSilverToGenshi.
Changed 5 years ago by francois_at_granade.com
- Attachment trac-with-userfilter-2.diff added
The first patch attached to this bug was slightly buggy (it would break the other types of filters). This new patch doesn't break anything.
The userfilter patch