Edgewall Software

Ticket #4672 (closed defect: fixed)

Opened 2 years ago

Last modified 2 years ago

empty svn:externals break trac browser

Reported by: Armin Ronacher Owned by: cboos
Priority: high Milestone: 0.11
Component: version control/browser Version: devel
Severity: normal Keywords: svn:externals
Cc:

Description

How to Reproduce

Define svn:externals but keep them empty.

System Information

Trac 0.11dev
Python 2.4.3 (#2, Oct 6 2006, 07:49:22)
[GCC 4.0.3 (Ubuntu 4.0.3-1ubuntu5)]
SQLite 3.2.8
pysqlite 2.0.5
Genshi 0.4dev-r493
Pygments 0.7
Subversion 1.3.1

Python Traceback

Traceback (most recent call last):
  File "/usr/lib/python2.4/site-packages/trac/web/main.py", line 401, in dispatch_request
    dispatcher.dispatch(req)
  File "/usr/lib/python2.4/site-packages/trac/web/main.py", line 213, in dispatch
    resp = chosen_handler.process_request(req)
  File "/usr/lib/python2.4/site-packages/trac/versioncontrol/web_ui/browser.py", line 326, in process_request
    node.get_properties()),
  File "/usr/lib/python2.4/site-packages/trac/versioncontrol/web_ui/browser.py", line 468, in render_properties
    return filter(None, [self.render_property(name, mode, context, props)
  File "/usr/lib/python2.4/site-packages/trac/versioncontrol/web_ui/browser.py", line 480, in render_property
    rendered = renderer.render_property(name, mode, context, props)
  File "/usr/lib/python2.4/site-packages/trac/versioncontrol/svn_fs.py", line 332, in render_property
    return self._render_externals(props[name])
  File "/usr/lib/python2.4/site-packages/trac/versioncontrol/svn_fs.py", line 347, in _render_externals
    localpath, rev, url = elements[0], None, elements[-1]
IndexError: list index out of range

Attachments

Change History

follow-up: ↓ 3   Changed 2 years ago by cboos

  • status changed from new to assigned
  • milestone set to 0.11

Define svn:externals but keep them empty.

Why on earth would you do that ;)

Ok, I didn't think about that, will fix.

  Changed 2 years ago by cboos

  • keywords svn:externals added
  • status changed from assigned to closed
  • resolution set to fixed
  • severity changed from critical to normal

Fixed by r4689.

in reply to: ↑ 1   Changed 2 years ago by Armin Ronacher

Replying to cboos:

Define svn:externals but keep them empty.

Why on earth would you do that ;)

Obviously because someone was unable to use svn propdel :D

Add/Change #4672 (empty svn:externals break trac browser)

Author


E-mail address and user name can be saved in the Preferences.


Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
to The owner will change from cboos. Next status will be 'closed'
 
Note: See TracTickets for help on using tickets.