Renaming a milestone doesn't update ticket history

[sdyson@…]

If you rename a milestone the milestone on associated tickets is updated to reflect the change. However in the ticket history, where it says 'milestone set to x' or 'milestone changed from x to y', the milestone name hasn't been updated. Only a minor issue but still a little irritating.

[Christian Boos]

This is an example of batch ticket change. #525 talks mainly about the UI for this, but we should also consider the problem from the API side.

This is even an example of a "cross resource" change set, as renaming a milestone also triggers a change in the milestone property of all the related tickets.

[osimons]

#5897 closed as duplicate.

[Christian Boos]

See also closely related #5658.

[Remy Blank]

See #5658 for the same issue when re-targeting tickets on milestone completion.

[Ryan J Ollos <ryan.j.ollos@…>]

I investigated this briefly as a possible follow-on to #5658 if the patch is accepted there. It looks like we'd want to add an author parameter to the update method. The delete method already has an author parameter. We'd have to decide whether notifications should be sent. I'd lean towards no notifications.

trac-trunk/trac/ticket/model.py

@@ -1048 +1048 @@
         for listener in TicketSystem(self.env).milestone_change_listeners:
             listener.milestone_created(self)
 
-    def update(self, db=None):
+    def update(self, db=None, author=None):
         """Update the milestone.
 
         :since 1.0: the `db` parameter is no longer needed and will be removed
@@ -1072 +1072 @@
                 # Update milestone field in tickets
                 self.env.log.info("Updating milestone field of all tickets "
                                   "associated with milestone '%s'", self.name)
+                when = datetime.now(utc)
+                comment = _("Milestone renamed.")
+                for id, in db("SELECT id FROM ticket WHERE milestone=%s", (old_name,)):
+                    t = Ticket(self.env, int(id))
+                    t['milestone'] = self.name
+                    t.save_changes(author, comment, when)
                 db("UPDATE ticket SET milestone=%s WHERE milestone=%s",
                    (self.name, old_name))
                 TicketSystem(self.env).reset_ticket_fields()

trac-trunk/trac/ticket/admin.py

@@ -268 +268 @@
                                             _('Invalid Completion Date'))
                     mil.description = req.args.get('description', '')
                     try:
-                        mil.update()
+                        mil.update(req.authname)
                     except self.env.db_exc.IntegrityError:
                         raise TracError(_('The milestone "%(name)s" already '
                                           'exists.', name=name))

[Christian Boos]

Is the patch in comment:6 the one to be reviewed or did you plan an update?

[Ryan J Ollos <ryan.j.ollos@…>]

Some updates might be needed after #5658 is integrated, and I also had some questions in comment:6, but I felt like the patch captured the essential changes that needed to be made.

Another option is that I could combine the two patches, so just let me know what is easiest to handle on your end. Either way, I'm around and have time to commit to furthering the patches, so I can follow-up with a new patch soon, or within a few days of #5658 being integrated.

[Ryan J Ollos]

See comment:50:ticket:5658 for a description of the changes.