[PATCH] - Display DateTime values in Query Results correctly

[ilias@…]

the patch enables the dispaly of 'time' and 'changetime' fields (if available), otherwise the behaviour remains the same:

​patch

It is identical to the patch suggested by mgood within ​this thread

See line 140 ​of this patch

[Christian Boos]

Thanks, though it looks preferable to do that based on type of the column.

query_div.html

@@ -45 +45 @@
             result.changed and ' changed' or ''}${
             result.removed and ' removed' or ''}">
             <py:for each="idx, header in enumerate(headers)" py:choose="">
-              <td py:when="idx == 0" class="id"><a href="$result.href" title="View ticket">#$result.id</a></td>
-              <td py:otherwise="" class="$header.name" py:choose="">
-                <a py:when="header.name == 'summary'" href="$result.href" title="View ticket">$result.summary</a>
-                <span py:otherwise="">${result[header.name]}</span>
-              </td>
+              <py:with vars="name = header.name; value = result[name]">
+                <td py:when="idx == 0" class="id"><a href="$result.href" title="View ticket">#$result.id</a></td>
+                <td py:otherwise="" class="$name" py:choose="">
+                  <a py:when="name == 'summary'" href="$result.href" title="View ticket">$value</a>
+                  <span py:when="isinstance(value, datetime)">${format_datetime(value)}</span>
+                  <span py:otherwise="">$value</span>
+                </td>
+              </py:with>
             </py:for>
           </tr>

[ilias@…]

Replying to cboos:

Thanks, though it looks preferable to do that based on type of the column.

…which is not yet defined.

I've 'back-developed' my patches to not affect the ticket api (as suggested by mgood):

​http://groups.google.com/group/trac-dev/msg/61c2134c408c1296

So, at this point the field type definition does not exist thus looking for 'datetime' would not work. The suggested patch does the work fine (until the fields api is refactored/extended).

templates/query_div.html

@@ -48 +48 @@
               <td py:when="idx == 0" class="id"><a href="$result.href" title="View ticket">#$result.id</a></td>
               <td py:otherwise="" class="$header.name" py:choose="">
                 <a py:when="header.name == 'summary'" href="$result.href" title="View ticket">$result.summary</a>
+                <span py:when="header.name in ('time', 'changetime')">${format_datetime(result[header.name])}</span>
                 <span py:otherwise="">${result[header.name]}</span>
               </td>
             </py:for>

[Christian Boos]

Note that I've checked directly the type of the value: isinstance(value, datetime)

[ilias@…]

Replying to cboos:

Note that I've checked directly the type of the value: isinstance(value, datetime)

Oh yes, I see (a little bit overworked).

This would be a more elegant generic solution.

Of course it should be prefered.

[ilias@…]

I've ​applied the patch and it works fine on the server, so for me it fine if it goes in trunk this way.

[Christian Boos]

Patch applied in r4292.