[PATCH] - Ticket Api does not contain 'time' and 'changetime' fields

[ilias@…]

source:trunk/trac/ticket/api.py@3935#L88​

The attached patch introduces the fields 'time' and 'changetime' to the ticket api.

This enables e.g. sorting on those fields within queries (ticket-query-macro).

(sidenote: "'type': 'text'" can be possibly changed later e.g. to "datetime", in order to allow formatting of the values within the UI)

context:  http://dev.lazaridis.com/base/wiki/PlanTicketQueryMacro

[cmlenz]

I've not tried the patch, but doesn't this mean those fields are going to be displayed among the other form fields on the newticket/ticket pages?

[ilias@…]

Replying to cmlenz:

I've not tried the patch, but doesn't this mean those fields are going to be displayed among the other form fields on the newticket/ticket pages?

yes, you are right.

I guess I've missinterpreted the meaning of "Ticket Api".

[ilias@…]

The Query uses "TicketSystem?(self.env).get_ticket_fields()" to get the ticket fields:

source:trunk/trac/ticket/query.py#rev=3935#L51​

'time' and 'changetime' are missing, thus ordering does not work.

possibly changing get_ticket_fields() to

get_ticket_fields(all=false)

This would keep existent behaviour, but would return those missing fields on request (setting all=true).

or alternatively

get_ticket_fields(for_gui=True)

would this be ok?

[ilias@…]

patch with added option "all_fields"

[mgood]

I'm -1 on this. The get_ticket_fields function is intended for fields that should be user-editable. The Ticket model class has attributes time_created and time_changed for accessing that information. I don't have problem with the query supporting filtering or sorting by the creation or changed date/time, but I don't think it requires adding those to get_ticket_fields.

[ThurnerRupert <rupert.thurner@…>]

Replying to mgood:

I'm -1 on this. The get_ticket_fields function is intended for fields that should be user-editable. The Ticket model class has attributes time_created and time_changed for accessing that information. I don't have problem with the query supporting filtering or sorting by the creation or changed date/time, but I don't think it requires adding those to get_ticket_fields.

what would you suggest to get all tickest closed in the last week/month? or the tickets closed by user x in the last month?

[ilias@…]

Replying to ThurnerRupert <rupert.thurner@gmail.com>:

what would you suggest to get all tickest closed in the last week/month? or the tickets closed by user x in the last month?

An answer to this would go out of the scope of this ticket, which is just the inclusion of the 'time' and 'changetime' fields into the 'get_ticket_fields' function.

see further comments within:

 http://groups.google.com/group/trac-dev/msg/7c9edb15d47434bb

a summary: include the fields into "get_ticket_fields" and ensure that systems using this function ignore the fields that they cannot handle.

I'll try to post a followup patch which covers the "add-filter" issue.

[ilias@…]

Replying to mgood:

I'm -1 on this. The get_ticket_fields function is intended for fields that should ...

due to temporary problems with trac-anti-spam, comment here:

 http://groups.google.com/group/trac-dev/msg/78fc1a819c87ea9f

[ilias@…]

Patch provided by mgood

[ilias@…]

please ignore the last attached file (TicketQueryMissingFieldsByMgood?.diff), as the patch does not work.

[ilias@…]

Replying to ilias@lazaridis.com:

I'll try to post a followup patch which covers the "add-filter" issue.

 http://dev.lazaridis.com/base/changeset/115

[cboos]

The get_ticket_fields API should be clarified, and more field types should be handled (dates among others).

Tentatively set to 0.11, if this fits with the current WorkFlow changes.

See also #2288 and #4966.

[cboos]

The latest patch related to #2288 also addresses this.

[cboos]

Fixed I believe?

[rblank]

Replying to cboos:

Fixed I believe?

Yes, fixed in [7588], tracked in #2288.