Edgewall Software

Ticket #3936 (closed defect: fixed)

Opened 23 months ago

Last modified 20 months ago

Wiki inconsistently interprets wiki formatting in wiki change comments

Reported by: ben@… Owned by: cboos
Priority: normal Milestone: 0.11
Component: wiki system Version: 0.10
Severity: normal Keywords: formatter context
Cc:

Description

Make a change to the wiki and use [[PageOutline]] in its change comment. Then observe:

  1. Page History shows [[PageOutline]]
  2. Timeline shows [[PageOutline]]
  3. Page diff shows the page's outline
  4. Timeline RSS feed shows timeline's outline (!)

It would be good to pick one behavior and stick to it.

Attachments

Change History

Changed 23 months ago by cboos

  • keywords formatter context added
  • owner changed from jonas to cboos
  • milestone set to 0.11

Known issue, which can't be solved until a context information is passed to the formatter. The "right" behavior in that case would be to output the outline of the comment itself.

To be able to output the page's outline in the comment text, we probably need to have "stacked" contexts, as suggested by athomas, and a syntax to access to the parent context (e.g. [[PageOutline(..)]]).

Changed 20 months ago by cboos

  • status changed from new to closed
  • resolution set to fixed

Fixed in r4451.

I should add that I finally didn't do it the way it was suggested in the comment above. The [[PageOutline]] currently operates on the wiki text which is currently being rendered, not one some wiki text (which one?) belonging to the main resource being rendered (the one of the current WikiContext).

This means in this particular case that a [[PageOutline]] in a Wiki comment will give the outline of that comment, when rendered in wiki_to_html mode (e.g. in the Wiki diff view or when viewing that specific version of a Wiki page).

Not terribly useful in this case, but there are many other scenario where this no surprise approach will be useful. Think a big comment in a ticket, a big code review comment later on, etc.

Add/Change #3936 (Wiki inconsistently interprets wiki formatting in wiki change comments)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
 
Note: See TracTickets for help on using tickets.