Warning message in Wiki Delete

[trac-ja@…]

Clicking Delete this version button in a wiki page, warning message (This is the only version the page, so the page will be removed completely!) is displayed, although there are multiple versions in that wiki page.

When this patch is applied, it will improve:

trac/wiki/web_ui.py

@@ -254 +254 @@
         self._set_title(req, page, 'delete')
         req.hdf['wiki'] = {'mode': 'delete'}
         if version is not None:
-            num_versions = 0
-            for v,t,author,comment,ipnr in page.get_history():
-                if v >= old_version:
-                    num_versions += 1;
-                    if num_versions > 1:
-                        break
             req.hdf['wiki'] = {'version': version, 'old_version': old_version,
-                               'only_version': num_versions == 1}
+                               'only_version': (old_version == 1 and version == 1)}
 
     def _render_diff(self, req, db, page):
         req.perm.assert_permission('WIKI_VIEW')

[Christian Boos]

Well, the loop you removed was there in case the version 1 got deleted somehow, but this is no longer possible due to the current restrictions that prevent removing arbitrary versions in the middle of the history. r3875 seems to be based on the same assumption, so I guess we can move in that direction (still there might be existing Trac Wikis lacking a version 1 …)

[trac-ja@…]

I understand. There're Wiki pages missing version 1. However, page.get_history() yeilds only one record-set when the page to be deleted has any version number, I think.

This is a patch for source:branches/0.10-stable@3941​ :

trac/wiki/web_ui.py

@@ -256 +256 @@
         if version is not None:
             num_versions = 0
             for v,t,author,comment,ipnr in page.get_history():
-                if v >= old_version:
-                    num_versions += 1;
-                    if num_versions > 1:
-                        break
+                num_versions += 1;
+                if num_versions > 1:
+                    break
             req.hdf['wiki'] = {'version': version, 'old_version': old_version,
                                'only_version': num_versions == 1}
 

[osimons]

This seems to be fixed as [5386:5387]. Closing.

BTW: See #4112 for a closely related discussion.