Edgewall Software
Modify

Ticket #3646 (closed defect: wontfix)

Opened 5 years ago

Last modified 13 months ago

Mime Viewer doesn't handle mixed line endings

Reported by: anonymous Owned by: rblank
Priority: lowest Milestone:
Component: general Version: devel
Severity: minor Keywords: patch renderer
Cc:
Release Notes:
API Changes:

Description

Attached is a file that exhibits this behavior (note the line endings on the first 3 lines.

Attachments

sample.diff (309 bytes) - added by anonymous 5 years ago.
I hope this works

Download all attachments as: .zip

Change History

Changed 5 years ago by anonymous

I hope this works

comment:1 Changed 5 years ago by cboos

  • Keywords patch renderer added
  • Milestone set to 1.0
  • Priority changed from normal to lowest
  • Severity changed from normal to minor

comment:2 Changed 22 months ago by cboos

  • Milestone changed from 1.0 to unscheduled

Milestone 1.0 deleted

comment:3 Changed 19 months ago by rblank

  • Milestone changed from triaging to 0.13
  • Owner changed from jonas to rblank

comment:4 Changed 13 months ago by rblank

  • Milestone 0.13 deleted
  • Resolution set to wontfix
  • Status changed from new to closed

I wouldn't consider sample.diff as having mixed line endings, but rather as having too many line endings. Here's the content as a Python string:

"Index: report/report_member_roster.asp\r\r\n"
"===================================================================\r\r\n"
"--- report/report_member_roster.asp\t(revision 192)\r\r\n"
"+++ report/report_member_roster.asp\t(working copy)\r\r\n"
"@@ -1,4 +1,4 @@\r\n"
" This is a test file\r\n"
"-That doesn't\r\n"
"+That does not\r\n"
" render\r\n"
" correctly.\r\n"

The first four lines have duplicate line endings, so there's an empty line after each line, which is invalid syntax. Python does in fact handle mixed line endings very well:

>>> "111\n222\r333\r\n444".splitlines()
['111', '222', '333', '444']

So I'm closing this as "wontfix".

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
to The owner will be changed from rblank. Next status will be 'closed'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.