system defaults in new trac.ini override global trac.ini

[cpinto@…]

I have defined a set of standard settings in a global trac.ini file and after doing a trac-admin initenv for a new project I noticed that the trac.ini settings for the project did contain keys defined in the global file with different values.

[cpinto@…]

the global trac.ini file (I've appended a _global suffix so that the file isn't overridden)

[cpinto@…]

the project's trac.ini after initenv

[Matthew Good]

What are you expecting the behavior to be? trac-admin always initializes trac.ini with the standard Trac default values. I guess you were expecting that the new trac.ini would either copy the values from the global config, or omit them so they didn't override the global config.

[coderanger@…]

Why not add

if self.config.site_config.has_option(section, name):

at trac/env.py​

[anonymous]

er, make that if not ...

[ilias@…]

I would suggest to ommit the values which exist in the global.ini.

Currently I have to manually delete the created entries.

[Christian Boos]

Possible fix for the issue: special case the None value to be an indicator of a globally set configuration option.

[Christian Boos]

An other possibility: attachment:comment_out_globally_set_options-r3717.diff​

With this solution, the entry will be written, but commented out, indicating that the actual value is taken from the global trac.ini file. This solution makes it easy to:

• fill in a different the value to override the globally configured one
• automatically take into account changes in the global trac.ini

[Christian Boos]

Any comment on the patch? Otherwise, I'll proceed and commit it later today.

[Christian Boos]

Above patch committed in r3744.