Edgewall Software
Modify

Ticket #3523 (closed defect: worksforme)

Opened 6 years ago

Last modified 5 years ago

SpamFilter refuses to load

Reported by: sgrayban@… Owned by: jonas
Priority: normal Milestone:
Component: general Version: devel
Severity: normal Keywords: SpamFilter
Cc:
Release Notes:
API Changes:

Description

I installed the newest dnspython and still the spam filter refuses to load.

Trac[loader] WARNING: Cannot load plugin spamfilter.ip_blacklist because it requires "dnspython>=1.3.5"

I have 1.4.0 installed.

Attachments

Change History

comment:1 Changed 6 years ago by sgrayban@…

I had to edit the setup.py and remove that [DNS] require from...

spamfilter.ip_blacklist = tracspamfilter.filters.ip_blacklist

to get this to load.

Looking at the code I don't even see where its checking for the version of dnspython in the first place. So its always going to fail to load.

comment:2 Changed 6 years ago by mgood

The requirements are checked by the setuptools package automatically. You need to install dnspython via setuptools so that the metadata is available:

easy_install dnspython

That command will automatically download and install it correctly.

However, the "[DNS]" part means it's an "extra" feature. So, the other parts of the spam filter should work correctly when "dnspython" is not available. Only the IP blacklisting component will be unavailable.

comment:3 Changed 6 years ago by mgood

  • Priority changed from high to normal

comment:4 follow-up: Changed 6 years ago by cmlenz

Yeah, the rest of the SpamFilter plugin (Akismet, Regexp, etc) should still work even if dnspython is not available (or not installed with the required metadata).

Matt, what part of this ticket requires action from us? I would've closed as “worksforme”, but maybe I'm missing something?

comment:5 in reply to: ↑ 4 Changed 6 years ago by anonymous

  • Resolution set to worksforme
  • Status changed from new to closed

Replying to cmlenz:

Matt, what part of this ticket requires action from us? I would've closed as “worksforme”, but maybe I'm missing something?

None. I just forgot to close it.

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
to The owner will be changed from jonas. Next status will be 'closed'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.