Edgewall Software

Ticket #3523 (closed defect: worksforme)

Opened 2 years ago

Last modified 2 years ago

SpamFilter refuses to load

Reported by: sgrayban@… Owned by: jonas
Priority: normal Milestone:
Component: general Version: devel
Severity: normal Keywords: SpamFilter
Cc:

Description

I installed the newest dnspython and still the spam filter refuses to load.

Trac[loader] WARNING: Cannot load plugin spamfilter.ip_blacklist because it requires "dnspython>=1.3.5"

I have 1.4.0 installed.

Attachments

Change History

  Changed 2 years ago by sgrayban@…

I had to edit the setup.py and remove that [DNS] require from...

spamfilter.ip_blacklist = tracspamfilter.filters.ip_blacklist

to get this to load.

Looking at the code I don't even see where its checking for the version of dnspython in the first place. So its always going to fail to load.

  Changed 2 years ago by mgood

The requirements are checked by the setuptools package automatically. You need to install dnspython via setuptools so that the metadata is available:

easy_install dnspython

That command will automatically download and install it correctly.

However, the "[DNS]" part means it's an "extra" feature. So, the other parts of the spam filter should work correctly when "dnspython" is not available. Only the IP blacklisting component will be unavailable.

  Changed 2 years ago by mgood

  • priority changed from high to normal

follow-up: ↓ 5   Changed 2 years ago by cmlenz

Yeah, the rest of the SpamFilter plugin (Akismet, Regexp, etc) should still work even if dnspython is not available (or not installed with the required metadata).

Matt, what part of this ticket requires action from us? I would've closed as “worksforme”, but maybe I'm missing something?

in reply to: ↑ 4   Changed 2 years ago by anonymous

  • status changed from new to closed
  • resolution set to worksforme

Replying to cmlenz:

Matt, what part of this ticket requires action from us? I would've closed as “worksforme”, but maybe I'm missing something?

None. I just forgot to close it.

Add/Change #3523 (SpamFilter refuses to load)

Author



Change Properties
<Author field>
Action
as closed
Next status will be 'reopened'
to The owner will change from jonas. Next status will be 'closed'
 
Note: See TracTickets for help on using tickets.