Edgewall Software
Modify

Opened 18 years ago

Closed 18 years ago

#3403 closed defect (fixed)

"source:" is not processed correctly with interwiki prefix

Reported by: greg@… Owned by: Christian Boos
Priority: high Milestone: 0.10
Component: wiki system Version: devel
Severity: major Keywords: intertrac
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description (last modified by Christian Boos)

In interwiki processing

source:trunk/Makefile works as expected
s:source:trunk/Makefile generates an invalid URL, however
s:browser:trunk/Makefile does work

Attachments (0)

Change History (4)

comment:1 by anonymous, 18 years ago

Owner: changed from Jonas Borgström to anonymous

comment:2 by anonymous, 18 years ago

Owner: changed from anonymous to Jonas Borgström

comment:3 by Christian Boos, 18 years ago

Description: modified (diff)
Keywords: intertrac added; interwiki removed
Milestone: 0.10
Owner: changed from Jonas Borgström to Christian Boos
Priority: normalhigh
Severity: normalmajor
Status: newassigned

You meant InterTrac here, not InterWiki.

But yes, the InterTrac code doesn't interpret links locally, but let the remote Trac do the job, relying on the fact that usually the same names are used for the module in link resolvers and requests URLs. However, this is not always the case, as your example shows.

A better solution would be a generic /intertrac/<link> request handler that would dispatch any <link> to the appropriate local object.

The advantage of the current approach is that Trac servers of any version can be targeted by an InterTrac link (at least for simple links).

I'll do at least the dispatching part for 0.10, as not only it will solve this issue, but also the long standing one with the log: InterTrac links, covers the comment: links, etc.

comment:4 by Christian Boos, 18 years ago

Resolution: fixed
Status: assignedclosed

Implemented in [3526:3528/trunk].

In order to make it work, pay attention to the <trac_prefix>.compat configuration option:

  • If set to true, the InterTrac links will be using the old-style, which won't accomodate all kind of TracLinks but is compatible with all Trac versions.
  • If set to false, the InterTrac links will use the new /intertrac/<link> dispatcher introduced in r3526, but of course, this means the targeted Trac has to run with r3526 or above.

Once compatilibity with versions older than 0.10 becomes less important, the default could be switched to false, but for now, compatiblity is the default.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christian Boos.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christian Boos to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.