Ticket #2888 (closed defect: fixed)
Opened 6 years ago
Last modified 5 years ago
Misleading behavior - preview Ticket change
| Reported by: | Felix Collins | Owned by: | ecarter |
|---|---|---|---|
| Priority: | highest | Milestone: | 0.11 |
| Component: | ticket system | Version: | 0.9 |
| Severity: | minor | Keywords: | preview |
| Cc: | kkiffe77@… | ||
| Release Notes: | |||
| API Changes: | |||
Description (last modified by mgood) (diff)
When one edits a ticket and hits the enter key, the behavior is to preview the ticket. The preview condition is not obvious. Unless the description is changed the only indication is the "#preview" on the end of the URL…
I propose that the preview button be shifted to reside next to the Description edit box and that the default action for the page (on hitting enter) is to submit changes.
I've entered this as a defect as I consider it a design defect. An alternative view is that it is an enhancement.
Attachments
Change History
comment:1 Changed 6 years ago by anonymous
Changed 6 years ago by Felix Collins
- Attachment TicketPreview0.9.3.patch added
patch to display draft background on ticket preview
comment:2 Changed 6 years ago by mgood
- Description modified (diff)
- Owner changed from jonas to mgood
- Priority changed from low to highest
- Status changed from new to assigned
I agree that the preview background is better than changing the "Enter" behavior.
comment:3 Changed 6 years ago by anonymous
- Severity changed from minor to blocker
comment:4 Changed 6 years ago by mgood
- Severity changed from blocker to minor
comment:5 Changed 6 years ago by anonymous
- Component changed from ticket system to version control
- Resolution set to invalid
- Status changed from assigned to closed
comment:6 Changed 6 years ago by eblot
- Component changed from version control to ticket system
- Resolution invalid deleted
- Status changed from closed to reopened
WFT?
comment:7 Changed 6 years ago by anonymous
- Type changed from defect to enhancement
comment:8 Changed 6 years ago by anonymous
- Type changed from enhancement to defect
comment:9 Changed 6 years ago by anonymous
- Cc kkiffe77@… added
- Keywords kk added
- Priority changed from highest to lowest
- Type changed from defect to task
test:
comment:10 Changed 6 years ago by eblot
- Keywords kk removed
- Priority changed from lowest to highest
- Type changed from task to defect
WTF?
This is not a test system!
comment:11 Changed 6 years ago by anonymous
- Resolution set to fixed
- Status changed from reopened to closed
comment:12 Changed 6 years ago by cmlenz
- Resolution fixed deleted
- Status changed from closed to reopened
Someone seems to think that this is a nice ticket to mess around with :-/
comment:13 Changed 6 years ago by anonymous
Why not block anonymous from changing properties then?
comment:14 Changed 6 years ago by anonymous
kmjmkh
comment:15 Changed 6 years ago by anonymous
Well, of course this must be a nice ticket to mess around with, as it is available from within the Sandbox(!). Let me explain how I got here:
- On the Trac homepage (http://trac.edgewall.org/) I clicked on the "SandBox" link in the text at the bottom of the page
- In the SandBox I clicked on the "View Tickets" tab
- Still assuming I'm in the SandBox, I clicked on "All Active Tickets"
- This ticket here was on top of the list, so I just clicked it
- Result: I got to this ticket while still assuming being _in_the_SandBox_ (!)
I guess that everbody else and their dog also assumed this…
ciao, daniel ;-)
comment:16 Changed 6 years ago by anonymous
- Owner changed from mgood to lirong@…
- Status changed from reopened to new
comment:17 Changed 6 years ago by mgood
- Owner changed from lirong@… to mgood
Why are you trying to change the owner?
comment:18 Changed 6 years ago by mgood
- Milestone set to 0.11
I'll try to get this in the next milestone.
comment:19 Changed 6 years ago by cboos
comment:20 Changed 5 years ago by cboos
- Keywords preview added
- Owner changed from mgood to ecarter
Eli worked on this topic, in the source:sandbox/pycon/ticket-preview@4990 branch.
comment:21 Changed 5 years ago by cboos
- Resolution set to fixed
- Status changed from new to closed
And athomas merge that branch in trunk, in r4986.
Reading a bit more about this issue it becomes apparent that it is to deal with browser s treating enter in different ways. I different proposal to that stated above is to put a Draft background behind the ticket when preview is hit.