Warn about lacking default settings on trac.ini on env upgrade

[Pedro Algarvio <ufs@…>]

Today on one of my env's when fixing a bug, I got a failed email message for my smtp_always_cc address that is pointing to that env's ezmlm mailing list. The problem is that ezmlm only accepts mail messages directly addressed by To: or Cc:. So I when to IRC and bdash elucidated me about allow_public_cc. It would be nice that trac on an env upgrade would fill in the missing parts for old trac.ini's, or at least warn the user so he could add them.

As I writed this, I also thought that it's probably better to have a smtp_always_cc and a smtp_always_bcc because I don't mind having the mailing-list address on Cc: but a personal address I might, and allow_public_cc doesn't allow me that.

[Emmanuel Blot]

Trac upgrade does produce a 'trac.ini.sample' file with all the default values, so you may want to compare your settings with the new default settings after an upgrade. Changing a existing configuration could be a source of errors and misconfiguration. Maybe an additional command in trac-admin could warn the user about the new available settings. I'm not sure though it is worth warning the user about ALL the settings she does not want to use: how differenciate the already but not defined settings from the brand new settings ?

About the second part of your email:
I agree with your remark, however I can tell you why the smtp_always_bcc as not (yet ?) being introduced, as I wrote this piece of code: I wanted to stick with the original behaviour of the trac notification, which always performed some kind of 'Bcc' as each email notification was sent to a single recipient (one email / recipient). The goal was to provide the same behaviour if the user did not change her trac.ini file.

If you think it is worth breaking the compatibility and introduce smtp_always_cc / smtp_always_bcc differenciation in 0.10, please log in a new ticket for this specific topic.

btw: report system is not about the email notifications, but the ticket queries ;-)

[Pedro Algarvio <ufs@…>]

K, will submit that ticket, and why am I not getting any mails of tickets I submit here on trac's site? Is it disabled?

About the first part of the ticket, why yet another command just to know that my trac.ini file has missing new setings? My opinion would go to let the user now that there are changes. For example:

# trac-admin /path/to/trac/env upgrade
upgrade complete.
NOTE: There are some new setting for your trac.ini,
please look at trac.ini.sample

[Christian Boos]

Yes, I think that the trac.ini.sample feature is very useful and shouldn't be missed (but I might be biaised :) ). Therefore I added a message similar to the one you suggested in r3012.

[Christopher Lenz]

Testing notification