Edgewall Software
Modify

Ticket #2854 (closed defect: fixed)

Opened 6 years ago

Last modified 2 years ago

TICKET_CREATE without TICKET_VIEW redirect to denied page

Reported by: gh@… Owned by: nkantrowitz
Priority: normal Milestone: 0.12
Component: ticket system Version: 0.9.4
Severity: normal Keywords: permission workflow
Cc:
Release Notes:
API Changes:

Description

We have users who have TICKET_CREATE permission, but not TICKET_VIEW.
These users get the 'permission denied' message when they are redirected to their newly created ticket after creating it.
To avoid that I created a quick patch that redirects users without TICKET_VIEW permission back to the newticket module instead of the ticket.

Attachments

Change History

comment:1 Changed 6 years ago by gh@…

The patch mentioned above:

Index: trac/ticket/web_ui.py
===================================================================
--- trac/ticket/web_ui.py       (revision 2983)
+++ trac/ticket/web_ui.py       (working copy)
@@ -146,6 +146,10 @@
             self.log.exception("Failure sending notification on creation of "
                                "ticket #%s: %s" % (ticket.id, e))
 
+       # offer NewTicket again if user is not allowed to view tickets
+        if not req.perm.has_permission('TICKET_VIEW'):
+               req.redirect(self.env.href.newticket())
+
         # Redirect the user to the newly created ticket
         req.redirect(self.env.href.ticket(ticket.id))
 

comment:2 Changed 6 years ago by cboos

I think it makes more sense to allow users
who have a TICKET_CREATE permission to see
at least the ticket they've just created, no?

With your change, they'll certainly get the
impression that their ticket was not created,
and they'll probably try once or twice more before
giving up...

comment:3 Changed 6 years ago by Markus Tacker <m@…>

You could also display a page which states that the ticket has been created and a link back to "New Ticket".

comment:4 Changed 5 years ago by sid

See also #3466 for restricting users from seeing tickets that are not their own.

comment:5 Changed 5 years ago by cboos

  • Component changed from general to ticket system
  • Keywords permission workflow added
  • Milestone set to 0.11

comment:6 Changed 2 years ago by rblank

  • Milestone changed from next-minor-0.12.x to 0.12
  • Resolution set to fixed
  • Status changed from new to closed

AFAICT, this was fixed on trunk in [7579].

comment:7 Changed 2 years ago by rblank

  • Owner changed from jonas to nkantrowitz
View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
to The owner will be changed from nkantrowitz. Next status will be 'closed'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.