sort by component oopses

[Andres Salomon <dilinger@…>]

Hi,

When sorting by component, I managed to trigger the following traceback:

Python traceback

Traceback (most recent call last):
  File "/usr/local/lib/python2.3/site-packages/trac/web/modpython_frontend.py", line 206, in handler
    dispatch_request(mpr.path_info, mpr, env)
  File "/usr/local/lib/python2.3/site-packages/trac/web/main.py", line 142, in dispatch_request
    dispatcher.dispatch(req)
  File "/usr/local/lib/python2.3/site-packages/trac/web/main.py", line 110, in dispatch
    resp = chosen_handler.process_request(req)
  File "/usr/local/lib/python2.3/site-packages/trac/ticket/report.py", line 116, in process_request
    resp = self._render_view(req, db, id)
  File "/usr/local/lib/python2.3/site-packages/trac/ticket/report.py", line 317, in _render_view
    rows.sort(sorter.sort)
AttributeError: 'tuple' object has no attribute 'sort'

The fix is pretty trivial; it is expected that execute_report() is returning lists, not tuples.

[Andres Salomon <dilinger@…>]

Fix column sort oops, against r2946.

[mgood]

The problem was apparently due to MySQLdb returning tuples from cursor.fetchall() instead of lists. I cleaned up the code a bit in [2947] to use sorted() instead of the comparator which fixes this as well.

[cmlenz]

Please don't reopen without a comment.