Edgewall Software
Modify

Opened 18 years ago

Closed 18 years ago

#2655 closed defect (fixed)

Repeated links in multiline comments

Reported by: Tim Hatch <trac@…> Owned by: Christopher Lenz
Priority: normal Milestone: 0.10
Component: version control/browser Version: devel
Severity: normal Keywords:
Cc: Branch:
Release Notes:
API Changes:
Internal Changes:

Description

There is a regression caused by r2769 in source:trunk/trac/mimeview/api.py for multiline blocks. I've verified it with the Clearsilver-generated code for both Python and CSS highlighting (I've only noticed it in the browser view). Here's my testcase:

"""
a http://google.com/
Test
Test
"""

The bug manifests itself as the following being displayed (without formatting, but you get the idea):

1 	"""
2 	a http://google.com/
3 	a http://google.comTest
4 	a http://google.comTest
5 	a http://google.com"""

The anchor tag (and text thus far on the line) appear to be reinserted on subsequent lines until the end of the comment block. This worked correctly prior to r2769. Looking at this changeset, I moved the question mark to more closely reproduce the prior behavior (making dot-star nongreedy, rather than making the capturing group optional).

I'll attach the patch in a second.

Attachments (1)

multiline-link-regexp-fix.diff (552 bytes ) - added by Tim Hatch <trac@…> 18 years ago.
Diff against trunk @ r2824

Download all attachments as: .zip

Change History (3)

by Tim Hatch <trac@…>, 18 years ago

Diff against trunk @ r2824

comment:1 by Christopher Lenz, 18 years ago

Milestone: 0.10
Owner: changed from Jonas Borgström to Christopher Lenz
Status: newassigned
Version: 0.9.3devel

comment:2 by Christopher Lenz, 18 years ago

Resolution: fixed
Status: assignedclosed

Fixed in [2828]. Thanks for the patch!

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Christopher Lenz.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Christopher Lenz to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.