Edgewall Software
Modify

Ticket #2655 (closed defect: fixed)

Opened 6 years ago

Last modified 6 years ago

Repeated links in multiline comments

Reported by: Tim Hatch <trac@…> Owned by: cmlenz
Priority: normal Milestone: 0.10
Component: version control/browser Version: devel
Severity: normal Keywords:
Cc:
Release Notes:
API Changes:

Description

There is a regression caused by r2769 in source:trunk/trac/mimeview/api.py for multiline blocks. I've verified it with the Clearsilver-generated code for both Python and CSS highlighting (I've only noticed it in the browser view). Here's my testcase:

"""
a http://google.com/
Test
Test
"""

The bug manifests itself as the following being displayed (without formatting, but you get the idea):

1 	"""
2 	a http://google.com/
3 	a http://google.comTest
4 	a http://google.comTest
5 	a http://google.com"""

The anchor tag (and text thus far on the line) appear to be reinserted on subsequent lines until the end of the comment block. This worked correctly prior to r2769. Looking at this changeset, I moved the question mark to more closely reproduce the prior behavior (making dot-star nongreedy, rather than making the capturing group optional).

I'll attach the patch in a second.

Attachments

multiline-link-regexp-fix.diff (552 bytes) - added by Tim Hatch <trac@…> 6 years ago.
Diff against trunk @ r2824

Download all attachments as: .zip

Change History

Changed 6 years ago by Tim Hatch <trac@…>

Diff against trunk @ r2824

comment:1 Changed 6 years ago by cmlenz

  • Milestone set to 0.10
  • Owner changed from jonas to cmlenz
  • Status changed from new to assigned
  • Version changed from 0.9.3 to devel

comment:2 Changed 6 years ago by cmlenz

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed in [2828]. Thanks for the patch!

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
The resolution will be deleted. Next status will be 'reopened'
to The owner will be changed from cmlenz. Next status will be 'closed'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.