Edgewall Software
Modify

Ticket #2581 (assigned enhancement)

Opened 5 years ago

Last modified 4 months ago

Add Paste Deploy support to the WSGI branch

Reported by: ianb@… Owned by: cmlenz
Priority: normal Milestone: triaging
Component: general Version: devel
Severity: normal Keywords: wsgi paste
Cc: ianb@…

Description

Attached is a patch (against the sandbox/wsgi branch) that implements a Paste Deploy entry point for trac. Using the sample deployment file (in the patch in docs/sample_deploy.ini) you can do:

paster serve docs/sample_deploy.ini

To get a working server. The configuration in that file just points to the Trac project directory, it doesn't put any of Trac's configuration in that file. The server in the sample is WSGIUtils, but any server can be used (e.g., flup's FastCGI or SCGI servers). The sample file also wraps the app in paste.lint, which checks for WSGI compliance (you wouldn't use this normally, but for testing and development it is useful).

This also changes setup.py to use setuptools, because that is needed for entry points. Strictly speaking this would not be necessary (you can just put paste.app_factory = trac.web.main:paste_app_factory in the deployment configuration instead of use = egg:Trac). But, eh. I'm a little surprised Trac isn't using setuptools already. Just changing the import from distutils.core to setuptools seems to work well enough for me.

Also two bugs are fixed; one when subdirectories of parent_dir are not loadable, and one for parent_dirs itself.

I haven't implemented env_paths in this patch -- it would probably mean collecting all the configuration variables and parsing them a bit (but would certainly be doable). I'm not sure what the threadsafety of Trac is, but if dispatch_request could be entered from multiple threads with different trac.env_path values and work that way, other dispatchers (like Paste#urlmap) could be used in addition to env_paths. It looks like Trac is probably already ready to be used like this (if it doesn't use globals to communicate configuration).

Attachments

paste-deploy.patch (3.6 KB) - added by ianb@… 5 years ago.
Patch

Change History

Changed 5 years ago by ianb@…

Patch

comment:1 Changed 5 years ago by cmlenz

  • Owner changed from jonas to cmlenz
  • Status changed from new to assigned
  • Milestone set to 0.10

Integration with Trac is definitely something we'd like to do long-term, however I'm not sure whether we're quite ready to move setup.py to setuptools yet… we have a lot of users on, ehem, rather “convervative" linux distros, where the whole situation around setuptools is somewhat fuzzy at this point.

But anyway, I'll look into the patch. Thanks!

comment:2 Changed 5 years ago by cmlenz

Doh, I meant “integration with Paste“, of course :-P

comment:3 Changed 5 years ago by ianb@…

Setuptools 0.6a9 also adds some support for those more conservative linux distros (from feedback from Debian), by allowing installations that look completely normal, but a .egg-info directory is created alongside the package (that contains metadata like entry_points.txt). This is enabled with --single-version-externally-managed

There's also the option of not using entry points, but using paste.app_factory to indicate the entry point explicitly. Paste doesn't have to be the exclusive of any other techniques for starting up the server.

comment:4 Changed 4 years ago by coderanger@…

  • Milestone changed from 0.10 to 0.11

The new setuptools branch is not going to be part of 0.10, and this should really wait until that is finalized.

comment:5 Changed 3 years ago by mgood

#5112 has been marked as a duplicate and mentions the  th:TracWsgiPlugin which implements Paste Deploy support for Trac.

comment:6 Changed 3 years ago by cboos

See also #5586.

comment:7 Changed 19 months ago by cboos

  • Milestone changed from 0.11-retriage to 2.0

comment:8 Changed 4 months ago by cboos

  • Milestone changed from 2.0 to unscheduled

Milestone 2.0 deleted

View

Add a comment

Modify Ticket

Change Properties
<Author field>
Action
as assigned
as The resolution will be set. Next status will be 'closed'
to The owner will be changed from cmlenz. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.