Ampersand following a short link

[moschny at ipd.uni-karlsruhe.de]

An ampersand put directly after a short reference is rendered incorrectly and creates a broken link.

Example: "ticket:1153&" is rendered as ticket:1153& ("ticket:1153&;" for trac 0.9.2) and the generated link ends in "...1153&amp".

If the ampersand is followed by whitespace, it should not be treated as part of the link target.

This is a left-over from ticket:1153.

[cboos]

Don't HTML escape the wiki text before parsing. The HTML escaping is instead done as a normal formatting step.

[cboos]

Updated the patch on #1153 against the current trunk.

Please review.

[moschny at ipd.uni-karlsruhe.de]

More escaping in formatter.py/_make_ext_link().

[moschny at ipd.uni-karlsruhe.de]

In trac/wiki/formatter.py/_make_ext_link(), url, text and title should be esacped, I think. Here's an updated patch.

BTW: How do I run the tests?

[cboos]

Ok. For the tests, I use:

PYTHONPATH=".;$PYTHONPATH" python trac/test.py

on Windows; similar stuff on Unix, simply replace ";" by ":".

[moschny at ipd.uni-karlsruhe.de]

Ok, thanks. The patched version passes all 416 tests.

[cboos]

Slightly modified attachment:dont_escape_wiki_text_beforehand-r2636.2.patch applied in r2644.