#2311 closed defect (fixed)
No notification email on owner change for the old owner
| Reported by: | Owned by: | Ryan J Ollos | |
|---|---|---|---|
| Priority: | normal | Milestone: | 1.0.2 |
| Component: | notification | Version: | 0.9 |
| Severity: | major | Keywords: | notification email |
| Cc: | webkontakt@…, shishz@…, greg@… | Branch: | |
| Release Notes: |
Send notification to previous owner when ticket owner is changed. |
||
| API Changes: | |||
| Internal Changes: | |||
Description
If you change the owner of a ticket, the old owner is not notified by email.
Changing the CC field, however, invokes notification also to those removed from CC. Owner changes should do as well.
Attachments (0)
Change History (32)
comment:1 by , 19 years ago
| Component: | general → ticket system |
|---|
comment:2 by , 19 years ago
| Cc: | added |
|---|
comment:3 by , 19 years ago
| Milestone: | 0.9.1 → 1.0 |
|---|
comment:4 by , 19 years ago
| Cc: | added |
|---|
comment:5 by , 19 years ago
| Keywords: | notification email added |
|---|
comment:6 by , 16 years ago
| Component: | ticket system → notification |
|---|
comment:7 by , 15 years ago
| Milestone: | 1.0 → unscheduled |
|---|
comment:8 by , 14 years ago
| Milestone: | triaging → next-major-0.1X |
|---|---|
| Owner: | changed from to |
comment:10 by , 14 years ago
| Cc: | added |
|---|
comment:11 by , 14 years ago
| Cc: | added |
|---|
comment:15 by , 12 years ago
The same issue (th:#6452) has been fixed now for th:AnnouncerPlugin in th:r12333.
comment:16 by , 12 years ago
| Severity: | minor → major |
|---|
I recently upgraded to Trac 1.0 - and I was shocked to notice that a workflow critical bug like this is still not fixed. To my understanding, it's just sending out one single additional email. I reported this bug in 2005(!), and it is "new", and not assigned to anyone.
Is there anything one could do to bring this up again? This behavior is seriously affecting our productivity.
comment:17 by , 12 years ago
| Milestone: | next-major-releases → 1.0.1 |
|---|
I think this should be fixed in the next version. Hope you don't disagree.
comment:18 by , 12 years ago
| Milestone: | 1.0.1 → next-major-releases |
|---|
Please don't change milestones without a good reason (no, "I want it and it's been open for 7 yeary" isn't; a patch might be). Thanks.
comment:19 by , 12 years ago
The patch in 25165a45 causes the previous owner to be notified when a ticket is reassigned. This was implemented by patterning the change after the way that prev_cc is handled: populating the field in _notify and then passing the value of the field as a parameter to the get_ticket_notification_recipients method.
The patch in bcd8df9a implements the same change in a different way, by isolating all of work in populating the recipients list to the get_ticket_notification_recipients method. I tend to think this leads to more readable code.
Neither patch causes the previous owner to be notified in the case of batch modification, and a similar pre-existing problem is that members removed from the CC list are not notified when the ticket is batch modified. It looks like the way to fix that issue is to pass the modtime to BatchTicketNotifyEmail.notify. The second of the two patches will probably make this problem easier to fix.
comment:20 by , 11 years ago
| Cc: | removed |
|---|---|
| Milestone: | next-major-releases → next-stable-1.0.x |
| Owner: | set to |
| Status: | new → assigned |
comment:21 by , 11 years ago
| Milestone: | next-stable-1.0.x → 1.0.3 |
|---|
comment:22 by , 11 years ago
Proposed changes can be found in log:rjollos.git:t2311.2. The intention is to only change the API in a way that is backwards compatible. Some of my earlier proposed changes would have changed the API in a non-backwards compatible way.
follow-up: 27 comment:23 by , 11 years ago
The unit tests may need some adjustment for execution on Windows in order to avoid the problems described in #11301 and comment:68:ticket:5658.
comment:24 by , 11 years ago
I'm working on parsing the monolithic changesets and adding more tests, and should have revised changes posted tomorrow.
comment:25 by , 11 years ago
Some refactoring was committed to 1.0-stable in [12384:12386] and merged to trunk in [12387].
comment:26 by , 11 years ago
| Milestone: | 1.0.3 → 1.0.2 |
|---|
Notification test cases refactored and extended in [12569]. Minor issue fixed in [12570]. Merged to trunk in [12571:12572].
comment:27 by , 11 years ago
| Release Notes: | modified (diff) |
|---|---|
| Resolution: | → fixed |
| Status: | assigned → closed |
Replying to rjollos:
The unit tests may need some adjustment for execution on Windows in order to avoid the problems described in #11301 and comment:68:ticket:5658.
I forgot about this potential issue. Jun, could you let me know if you spot any test failures on Windows?
Committed to 1.0-stable in [12580:12581]. Merged to trunk in [12582:12583].
comment:29 by , 7 years ago
r12569 removed the usage of trac.tests.notification.smtp_address. It is proposed for removal in pull request 20. The function uses an undefined variable start. Should we just remove the function, or deprecated it for removal in 1.5.1? It's possible some plugin is using it, but I think probably unlikely.
follow-up: 31 comment:30 by , 7 years ago
Can a plugin use a function trac.tests? Looking at my install of Trac, I don't see any test packages.
comment:31 by , 7 years ago
Replying to Tim Graham <timograham@…>:
Can a plugin use a function
trac.tests? Looking at my install of Trac, I don't see any test packages.
It cannot, good point. The test API functions and classes can be found in test.py files. We might consider moving some of the notification test API to trac/notification/test.py.
Milestone 1.0 deleted