[patch] Notification mails use LF instead of CRLF

[m.kooijman@…]

About half the newlines in notify emails are generated as LF instead of CRLF, which causes some mailservers to just remove them and screwing up formatting for the notify message and making email notification not workable. (I have observed a direct path using only exim and/or postfix to work, but when run via exim, ESMTP and fetchmail, it broke).

I have been playing around with a few fixes, some of which refused to work at first for some weird reason. Anyway, I've found two sources of LF:

• The email template is a file with newlines. I think setting svn:eol-style = CRLF on this file should do the trick.
• A few hardcoded '\n' in Notify.py. Replacing these with the CRLF constant fixes that.

Tested with 0.9b1, but there are no relevant changes in b2 or trunk which would fix this.

Priority set to high, since this makes email notification unusable on some systems.

[m.kooijman@…]

Patch for this problem, made against 0.9b1, but should apply cleanly against latest trunk

[m.kooijman@…]

Same file, but with two lines of debug code removed. Oops…

[m.kooijman@…]

To show the problem: ​This how I received the email message of the last change. Notice the missing newlines… (Kinda takes the poing out of the signature, doesn't it? ;-)

[Christopher Lenz]

Looks good.

[Christopher Lenz]

Applied modified patch in [2329]. Please test.

[m.kooijman@…]

Works :-)

[Norbert Unterberg <nunterberg@…>]

Does this also fix Ticket #1139? I can't try right now…

[Matthijs Kooijman <m.kooijman@…>]

I wouldn't know, I've never experienced #1139. Can you check later?