Ticket #1660 (new enhancement)
Opened 7 years ago
Last modified 8 months ago
Patch to get email notification (with diff) of wiki changes
| Reported by: | pierre.palatin+trac@… | Owned by: | cboos |
|---|---|---|---|
| Priority: | normal | Milestone: | next-major-0.1X |
| Component: | notification | Version: | devel |
| Severity: | critical | Keywords: | notification email nosylist |
| Cc: | luca.ceresoli@…, stoile@…, itamarost@…, tiago@… | ||
| Release Notes: | |||
| API Changes: | |||
Description
This is a little patch to get notification, with diff included, of wiki changes.
That's implemented against trunk/, revision 1777, as a component.
I did'nt know where to put plugins, so I put it in Notify.py (I use NotifyEmail? class), but I don't like that too much ...
(patch follows ...)
Attachments
Change History
Changed 7 years ago by pierre.palatin+trac@…
- Attachment wikimail-patch-1.diff added
comment:1 Changed 6 years ago by ytse@…
This feature is useful, but get_recipients() looks too simple. It would be a great deal if a user could control the notification by oneself. It may by a watch-list of wiki pages in user's settings or something else...
Let us see how other wikies do it.
comment:2 Changed 6 years ago by cmlenz
- Component changed from general to wiki
comment:3 Changed 6 years ago by cmlenz
See also #576.
comment:4 Changed 6 years ago by cboos
- Keywords notification email added
See also #1459, which discusses a redesign of the ticket CC field.
Transposed here, the idea of a nosy list for a Wiki page is also interesting,
as anyone who contributes to a Wiki page is potentially interested in what
follows-up...
comment:5 Changed 6 years ago by husted@…
Let us see how other wikies do it.
Typically, the email address comes from the user profile, rather than being input with the change. The user profile will have settings that determine whether and/or what kind of notifications are issued. For example, sometimes you can opt-out of alerts for your own changes.
Confluence lets you watch a space, so that you can get email alerts for any change to any page in the space. You can also opt-in for a daily change summary.
Moin-Moin also lets you subscribe to pages using a regex. You can use ".*" to subscribe to all changes, or another expression to subscribe to a smaller set. The UI will also add an individual page to the list for you.
Both have a "trivial change" setting you can check. Subscribers can then "opt-out" of trivial changes.
Adding wiki email notification seems like a "must-have" feature for a 1.0 release, since it is now a standard feature of similar products, that many people (including myself) consider essential.
HTH, Ted.
comment:6 Changed 6 years ago by cboos
- Milestone set to 1.0
- Owner changed from jonas to cboos
More general notifications certainly need to make it for 1.0,
if not sooner.
Alect an me have already discussed a bit about this and the need
to make notifications react on change listeners.
comment:7 Changed 5 years ago by cboos
- Milestone changed from 1.0 to 0.11
- Priority changed from normal to high
Generic change listener interface coupled with notification should be defined.
This is somehow related to the propagation of "contexts" of changes that will be introduced at the wiki level.
Adapters to the 0.10 compatible APIs could be written on top of that.
comment:8 Changed 5 years ago by Noah Kantrowitz (coderanger) <coderanger@…>
The WikiNotification plugin will do this for 0.10.
Changed 5 years ago by jason@…
- Attachment wikimail-patch-against-0.10.diff added
Updated patch which applies to trac 0.10
comment:9 follow-up: ↓ 10 Changed 5 years ago by jason@…
I have updated the patch to apply cleanly to (and function correctly) with trac 0.10.
comment:10 in reply to: ↑ 9 Changed 5 years ago by mgood
Replying to jason@peaceworks.ca:
I have updated the patch to apply cleanly to (and function correctly) with trac 0.10.
It looks like you forgot part of the patch, since it only includes the template and not the associated code changes.
comment:11 Changed 5 years ago by stelian.iancu@…
So is this going to svn commit anytime soon?
comment:12 Changed 5 years ago by cboos
- the patch attached here will most likely not be integrated in the 0.10 branch, as 0.10.x releases are mostly bug fix releases; they only get minor enhancements that can be easily backported from trunk
- the real fix for this feature (eventually for 0.11) is getting nearer, as I recently made some progresses on the architecture changes needed for this to happen (see TracDev/Proposals /Journaling if you're interested in the details). I'd certainly make use of the contributed patches in some way or another.
comment:13 Changed 5 years ago by cboos
comment:14 Changed 5 years ago by cboos
- Milestone changed from 0.11 to 0.12
Most probably not for 0.11.
comment:15 Changed 4 years ago by Piotr Kuczynski <piotr.kuczynski@…>
- Component changed from wiki system to notification
comment:16 Changed 3 years ago by Luca Ceresoli <luca.ceresoli@…>
- Cc luca.ceresoli@… added
comment:17 Changed 3 years ago by stoile@…
- Cc stoile@… added
I'm very interested in this Feature, too.
comment:18 Changed 20 months ago by rblank
- Milestone changed from next-major-0.1X to unscheduled
comment:19 Changed 20 months ago by cboos
- Milestone changed from unscheduled to next-major-0.1X
- Priority changed from high to normal
- Severity changed from normal to critical
Keeping on the long term plan, however this is a very important feature to have, as it makes it possible to have well maintained pages through a micro community of editors interested in that page only.
comment:20 Changed 16 months ago by itamaro
- Cc itamarost@… added
I'm confused - what's the difference between this enhancement and #2293?
comment:21 Changed 16 months ago by cboos
- Keywords nosylist added
The mechanism of notification is quite different (push vs. pull to make it short).
#2293 is about RSS readers regularly querying for changes (pull) that happened to a given page (or hierarchy subset), the same way as the timeline RSS feed restricted to the wiki changes would get you the changes for all pages.
Here, we're talking about sending a mail after each change (push), in a similar way we do for ticket changes. However, we probably don't want to reimplement the Cc: system for the wiki, with all its quirks and limitations. We rather need something like nosy list of RoundUp (#8637).
comment:22 Changed 13 months ago by DMcLean <dmclean@…>
I would like to see this change as well.
comment:23 Changed 8 months ago by tiago@…
- Cc tiago@… added



initial version of wiki changes email notification patch