Modify ↓
Opened 19 years ago
Closed 17 years ago
#1603 closed defect (wontfix)
default_dir() should catch AttributeError
| Reported by: | Manuzhai | Owned by: | Jonas Borgström |
|---|---|---|---|
| Priority: | low | Milestone: | |
| Component: | general | Version: | devel |
| Severity: | normal | Keywords: | setup siteconfig |
| Cc: | manuzhai@… | Branch: | |
| Release Notes: | |||
| API Changes: | |||
| Internal Changes: | |||
Description
I have an old siteconfig.py from 0.8, which has no default_macros_dir. Now, trac-admin upgrade will not run because import succeeds (siteconfig.py just exists, from the old version), but the module doesn't contain the attribute it needs. I think this could just be fixed by having the except clause in config.default_dir() also take an AttributeError, but I'm not sure. (Of course it's a bit sloppy to have a stale siteconfig.py lying around, but it's still nice to be robust in these cases.)
Attachments (0)
Change History (2)
comment:1 by , 17 years ago
comment:2 by , 17 years ago
| Keywords: | setup siteconfig added |
|---|---|
| Resolution: | → wontfix |
| Status: | new → closed |
Well, in 0.11, there won't be a siteconfig.py anymore, as you can see in source:sandbox/setuptools/setup.py
Note:
See TracTickets
for help on using tickets.
Looks like this still isn't happening in trunk — source:trunk/trac/config.py#L419