Edgewall Software
Modify

Opened 5 months ago

Closed 5 months ago

Last modified 5 months ago

#13629 closed defect (fixed)

trac-svn-hook should refer to python3, not python

Reported by: Dimitry Andric <dimitry@…> Owned by: Jun Omae
Priority: normal Milestone: 1.6.1
Component: contrib Version: 1.6
Severity: normal Keywords:
Cc: Branch:
Release Notes:
  • Removed checking python -V because of checking trac-admin -v.
  • Use python3 rather than python in shebang.
API Changes:
Internal Changes:

Description

https://trac.edgewall.org/browser/trunk/contrib/trac-svn-hook appears to have not been updated in some time. Meanwhile trac itself, and particularly trac-admin, use python3. However trac-svn-hook still checks for the existence of "python":

https://trac.edgewall.org/browser/trunk/contrib/trac-svn-hook#L203

Either this check should be updated to python3, or maybe it should be removed?

I would guess the existence of "trac-admin" in the PATH should be enough. If that script is run, and the shebang interpreter is not found, you should already get an error. However, it may not be as clear as "python3 not found".

Attachments (0)

Change History (5)

comment:1 by Dimitry Andric <dimitry@…>, 5 months ago

An alternative workaround is to install the python-is-python3 package, at least on Debian and Ubuntu distributions. (That might cause other unwanted effects though, which is why it is not installed by default on these distributions.)

comment:2 by Jun Omae, 5 months ago

Branch: trunk

comment:3 by Jun Omae, 5 months ago

Milestone: 1.6.1
Owner: set to Jun Omae
Status: newassigned

Makes sense.

comment:4 by Jun Omae, 5 months ago

Release Notes: modified (diff)
Resolution: fixed
Status: assignedclosed

Fixed in [17757:17758] and merged in [17759].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jun Omae.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jun Omae to the specified user.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.