Edgewall Software
Modify

Opened 5 years ago

Last modified 3 years ago

#13215 new defect

Adding a repository does NOT trim trailing blanks

Reported by: strk@… Owned by:
Priority: normal Milestone: 1.7.1
Component: version control Version: 1.2.2
Severity: normal Keywords:
Cc: Branch:
Release Notes:

Fixed surrounding whitespace not removed when adding a repository from the repository admin page.

API Changes:
Internal Changes:

Description

Adding a new git repository fails to remove trailing blanks from the repository path. It took some time for me to figure out.

This happened with trac 1.2.2, I didn't test newer versions

Attachments (0)

Change History (15)

comment:2 by Jun Omae, 5 years ago

Component: plugin/gitversion control
Type: defectenhancement

comment:3 by Jun Omae, 5 years ago

Milestone: undecided

comment:4 by Ryan J Ollos, 5 years ago

Milestone: undecided1.2.6

I will try to fix for the upcoming release.

Last edited 5 years ago by Ryan J Ollos (previous) (diff)

comment:5 by Ryan J Ollos, 5 years ago

Milestone: 1.2.61.4.2
Owner: set to Ryan J Ollos
Status: newassigned

comment:6 by Ryan J Ollos, 4 years ago

Release Notes: modified (diff)

comment:7 by Ryan J Ollos, 4 years ago

Proposed changes in log:rjollos.git:t13215_repository_admin_strip_trailing.

#12925 will improve error raising and handling, and test coverage of RepositoryAdminPanel and DbRepositoryProvider.

comment:8 by Ryan J Ollos, 4 years ago

Need to do the same when adding an alias, and make sure the informational message about resyncing has the spaces removed from the repository name.

comment:9 by Ryan J Ollos, 4 years ago

Type: enhancementdefect

comment:10 by Ryan J Ollos, 4 years ago

Milestone: 1.4.21.4.3

comment:11 by Ryan J Ollos, 4 years ago

Milestone: 1.4.31.5.3

comment:12 by Ryan J Ollos, 4 years ago

Milestone: 1.5.31.7

comment:13 by Ryan J Ollos, 3 years ago

Milestone: 1.71.7.1

Milestone renamed

comment:14 by Ryan J Ollos, 3 years ago

Milestone: 1.7.1
Owner: Ryan J Ollos removed
Status: assignednew

comment:15 by Ryan J Ollos, 3 years ago

Milestone: 1.7.1

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The ticket will remain with no owner.
The ticket will be disowned.
as The resolution will be set. Next status will be 'closed'.
The owner will be changed from (none) to anonymous. Next status will be 'assigned'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.