TravisCI test failures running on Ubuntu Trusty

[Ryan J Ollos]

There was a ​build failure yesterday when our tests ran on Trusty rather than precise.

Copied from 12833#comment:7:

• ​python-subversion is not yet available in packages, although the logs show that it gets installed. SVN tests are skipped with (no svn bindings).
• There's one failure:

  ERROR: runTest (trac.db.tests.functional.DatabaseBackupTestCase)
  
  Testing backup
  
  Traceback (most recent call last):
    File "/home/travis/build/rjollos/trac/trac/db/tests/functional.py", line 26, in runTest
      backup_file = env.backup()
    File "/home/travis/build/rjollos/trac/trac/env.py", line 716, in backup
      return DatabaseManager(self).backup(dest)
    File "/home/travis/build/rjollos/trac/trac/db/api.py", line 572, in backup
      return connector.backup(dest)
    File "/home/travis/build/rjollos/trac/trac/db/mysql_backend.py", line 280, in backup
      msg=to_unicode(errmsg.strip())))
  TracError: mysqldump failed: mysqldump: Got error: 1045: Access denied for user 'tracuser'@'localhost' (using password: NO) when trying to connect
  ----------------------------------------------------------------------
  Ran 205 tests in 357.456s
  FAILED (errors=1)
  make: *** [functional-test] Error 1
  

MySQL tests on Precise:

  Package        Version
  ------------------------------------------------------
  Python       : 2.7.3 (default, Dec 18 2014, 19:10:20) 
               : [GCC 4.6.3]
  Setuptools   : 12.0.5
  Jinja2       : 2.9.6
  Genshi       : 0.7 (with speedups)
  Babel        : 2.4.0
  sqlite3      : 2.6.0 (3.7.9)
  PySqlite     : not installed
  PyMySQL      : 0.7.11.None
  Psycopg2     : not installed
  SVN bindings : 1.6.17 (r1128011)
  Mercurial    : 2.0.2
  Pygments     : 2.2.0
  Textile      : 2.3.12
  Pytz         : 2017.2
  Docutils     : 0.13.1
  Twill        : 0.9
  LXML         : 3.8.0
  coverage     : not installed
  figleaf      : not installed

MySQL tests on Trusty:

  Package        Version
  ------------------------------------------------------
  Python       : 2.7.6 (default, Oct 26 2016, 20:30:19) 
               : [GCC 4.8.4]
  Setuptools   : 36.0.1
  Jinja2       : 2.9.6
  Genshi       : 0.7 (with speedups)
  Babel        : 2.4.0
  sqlite3      : 2.6.0 (3.8.2)
  PySqlite     : not installed
  PyMySQL      : 0.7.11.None
  Psycopg2     : not installed
  SVN bindings : not installed
  Mercurial    : not installed
  Pygments     : 2.2.0
  Textile      : 2.3.12
  Pytz         : 2017.2
  Docutils     : 0.13.1
  Twill        : 0.9
  LXML         : 3.8.0
  coverage     : not installed
  figleaf      : not installed

Subversion 1.8.8 is available on Precise.

[Ryan J Ollos]

Trusty has:

MySQL: 5.6.33-0ubuntu0.14.04.1

Precise has:

MySQL: 5.5.41-0ubuntu0.12.04.1-log

I would guess the problem is somehow with the MYSQL_PWD environment variable​.

[Jun Omae]

I'm using Ubuntu 14.04 with ​MySQL 5.5. I try to fix it after switching to ​MySQL 5.6.

[Jun Omae]

Hmm. Cannot reproduce it. All tests pass with MySQL 5.6. It seems mysqldump with MYSQL_PWD works.

$ mysqldump --version
mysqldump  Ver 10.13 Distrib 5.6.33, for debian-linux-gnu (x86_64)
$ MYSQL_PWD=password mysqldump -h localhost -u tracuser trac_utf8mb4 | head -3
-- MySQL dump 10.13  Distrib 5.6.33, for debian-linux-gnu (x86_64)
--
-- Host: localhost    Database: trac_utf8mb4
...

[Jun Omae]

If [client] password is configured in ~/.my.cnf, MYSQL_PWD environment variable is unused. According to ​MySQL 5.7 Reference Manual, the variable is the default password when connecting to mysqld.

$ cat ~/.my.cnf
[client]
password =
$ MYSQL_PWD=password mysqldump -h localhost -u tracuser trac_utf8mb4
mysqldump: Got error: 1045: Access denied for user 'tracuser'@'localhost' (using password: NO) when trying to connect

Work around is to add --no-defaults option, [7753c0b86/jomae.git]:

$ MYSQL_PWD=password mysqldump --no-defaults -h localhost -u tracuser trac_utf8mb4
-- MySQL dump 10.13  Distrib 5.6.33, for debian-linux-gnu (x86_64)
--
-- Host: localhost    Database: trac_utf8mb4
...

[Ryan J Ollos]

That makes sense. Looks like it may have been previously reported in #12698.

[Jun Omae]

Committed in [16199] and merged in [16200-16201].

[Jun Omae]

Replying to Ryan J Ollos:

Copied from 12833#comment:7:

• ​python-subversion is not yet available in packages, although the logs show that it gets installed. SVN tests are skipped with (no svn bindings).

I think this issue is caused by difference about system-site-packages of python2.7_with_system_site_packages virtualenv between trusty and precise.

Trusty

python2.7_with_system_site_packages on trusty is created without --system-site-packages. no-global-site-packages.txt file exists in lib directory:
​https://travis-ci.org/jun66j5/trac/builds/262106620#L466

Precise

python2.7_with_system_site_packages on precise is created with --system-site-packages. no-global-site-packages.txt file doesn't exist in lib directory:
​https://travis-ci.org/jun66j5/trac/builds/262106471#L261

[Jun Omae]

Work around is to delete no-global-site-packages.txt file when python version is 2.7_with_system_site_packages. See ​https://travis-ci.org/jun66j5/trac/jobs/262116580#L657.

.travis.yml

@@ -51 +52 @@
       pip --version
     fi
 install:
+  - |
+    if [ "$TRAVIS_PYTHON_VERSION" = "2.7_with_system_site_packages" ]; then
+      no_global="$HOME/virtualenv/python2.7_with_system_site_packages/lib/python2.7/no-global-site-packages.txt"
+      if [ -f "$no_global" ]; then rm -v "$no_global"; fi
+      python -c 'from svn import core'
+    fi
   - test -d "$HOME/.pip" || mkdir "$HOME/.pip"
   - ( echo "[global]"; echo "cache-dir = $HOME/.cache/pip" ) >"$HOME/.pip/pip.conf"
   - pip install --upgrade pip

[Ryan J Ollos]

On Linux and OSX I've used symlinks to avoid using --system-site-packages. On OSX my script is:

svn_python=$(locate -l 1 svn-python) > /dev/null
site_packages=pve/lib/python2.7/site-packages
[ ! -h $site_packages/svn ] && ln -s $svn_python/svn $site_packages/
[ ! -h $site_packages/libsvn ] && ln -s $svn_python/libsvn $site_packages/
[ ! -f $site_packages/svn.pth ] &&  echo $svn_python/libsvn > $site_packages/svn.pth

I don't know if that would also work for this case.

[Jun Omae]

Yes. Using symlinks also works well. See ​https://travis-ci.org/jun66j5/trac/builds/262514664#L644.

.travis.yml

@@ -51 +51 @@
       pip --version
     fi
 install:
+  - |
+    print_version='import sys; print("%d.%d" % sys.version_info[:2])'
+    if [ "$(/usr/bin/python -c "$print_version")" = "$(python -c "$print_version")" ]; then
+      print_sitelib='from distutils.sysconfig import get_python_lib; print(get_python_lib())'
+      sitelib_global="$(/usr/bin/python -c "$print_sitelib")"
+      sitelib_venv="$(python -c "$print_sitelib")"
+      ln -s "$sitelib_global/svn" "$sitelib_venv/svn"
+      ln -s "$sitelib_global/libsvn" "$sitelib_venv/libsvn"
+      python -c 'from svn import core'
+    fi
   - test -d "$HOME/.pip" || mkdir "$HOME/.pip"
   - ( echo "[global]"; echo "cache-dir = $HOME/.cache/pip" ) >"$HOME/.pip/pip.conf"
   - pip install --upgrade pip
@@ -89 +99 @@
       python: "2.6"
       env: tracdb=mysql
     - os: linux
-      python: "2.7_with_system_site_packages"
+      python: "2.7"
       env: tracdb=
     - os: linux
-      python: "2.7_with_system_site_packages"
+      python: "2.7"
       env: tracdb=sqlite
     - os: linux
-      python: "2.7_with_system_site_packages"
+      python: "2.7"
       env: tracdb=postgres
     - os: linux
-      python: "2.7_with_system_site_packages"
+      python: "2.7"
       env: tracdb=mysql
     - os: osx
       language: generic

[Ryan J Ollos]

Thanks. Interesting that it works without the svn.pth. For some reason I have always found it necessary to create that file.

I imagine you have already considered this for the final yml configuration - we might want to conditionally add the svn lib bindings to the environment only when "$build" != minimum .

[Jun Omae]

Thanks. I forgot minimum build.

Revised changes, I added "$TRAVIS_OS_NAME" = linux and "$build" != minimum:

jomae.git@t12880_svn_symlink+1.2	​https://travis-ci.org/jun66j5/trac/builds/262757049
jomae.git@t12880_svn_symlink+1.0	​https://travis-ci.org/jun66j5/trac/builds/262951626

[Ryan J Ollos]

Looks good to me.

[Jun Omae]

Committed in [16203] and merged in [16204-16205].

[Ryan J Ollos]

Milestone renamed