Log reason for not rendering diff

[Ryan J Ollos]

We could add some logging to make issues like ​gmessage:trac-users/-3XUG15vxcs/O4EvLXE_BAAJ easier to discover.

[Ryan J Ollos]

Changes in [26dbf899/rjollos.git].

[Peter Suter]

Good idea!

The line​ diff_bytes = diff_files = 0 could be moved inside the if self.max_diff_bytes or self.max_diff_files statement, right?

Maybe even nicer would be showing a message similar to the message that is displayed when the file content is omitted​ due to exceeding [mimeviewer] max_preview_size.

[Ryan J Ollos]

Replying to Peter Suter:

Maybe even nicer would be showing a message similar to the message that is displayed when the file content is omitted​ due to exceeding [mimeviewer] max_preview_size.

That is a better idea.

I think we could improve the styling of the message, but I made it consistent with the message on the preview page:

Both messages are shown if both constraints are violated:

The 100 bytes is a link to TracIni#changeset-max_diff_bytes-option (if allowed by permission check).

The 2 files is a link to TracIni#changeset-max_diff_files-option (if allowed by permission check).

[Ryan J Ollos]

Proposed changes in log:rjollos.git:t12761_max_size_warning. The changes are a bit complex because the py:strip can't be nested - the i18n:msg directive ​does not support nested directives.

Please note that i18n:msg directives do not support other nested directives. Directives commonly change the structure of the generated markup dynamically, which often would result in the structure of the text changing, thus making translation as a single message ineffective.

[Ryan J Ollos]

Committed to 1.2-stable in r15787.

Proposed changes for trunk in [e1b40cb1/rjollos.git].

[Ryan J Ollos]

Committed to trunk in r15797.