Edgewall Software
Modify ↓

Opened 8 years ago

Closed 8 years ago

#12467 closed defect (fixed)

Unit test failure with pytz 2016.4

Reported by: Ryan J Ollos Owned by: Jun Omae
Priority: normal Milestone: 0.12.8
Component: general Version:
Severity: normal Keywords: pytz
Cc: Branch:
Release Notes:

Fix unit tests failing with pytz 2016.4.

API Changes:
Internal Changes:

Description 

======================================================================
FAIL: test_pytz_moscow (trac.util.tests.datefmt.LocalTimezoneTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/rjollos/Documents/Workspace/trac-dev/teo-rjollos.git/trac/util/tests/datefmt.py", line 1989, in test_pytz_moscow
    self._compare_pytz(tz, '1992-03-28T23:00')  # +1:00 (DST start)
  File "/Users/rjollos/Documents/Workspace/trac-dev/teo-rjollos.git/trac/util/tests/datefmt.py", line 1925, in _compare_pytz
    self._compare_pytz_arithmetic(tz, dt_naive)
  File "/Users/rjollos/Documents/Workspace/trac-dev/teo-rjollos.git/trac/util/tests/datefmt.py", line 1889, in _compare_pytz_arithmetic
    self.assertEqual(dt_tz.isoformat(), dt_localtz.isoformat())
AssertionError: '1992-03-28T23:00:00+03:00' != '1992-03-29T00:00:00+04:00'

----------------------------------------------------------------------
Ran 2139 tests in 166.387s

FAILED (failures=1)
make: *** [unit-test] Error 1

Attachments (0)

Change History (2)

comment:1 by Jun Omae, 8 years ago

Owner: set to Jun Omae
Status: new → assigned

It seems changes tz database betweeen 2016c and 2016d lead the failure.

I'll modify or remove the test case.

comment:2 by Jun Omae, 8 years ago

Milestone: 1.0.11 → 0.12.8
Release Notes: modified (diff)
Resolution: → fixed
Status: assigned → closed

Fix in [14737] and merged in [14738,14739].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Jun Omae.
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from Jun Omae to the specified user.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.