Ticket #1246 (closed defect: fixed)
Opened 7 years ago
Last modified 5 years ago
Diff display in konqueror
| Reported by: | kilian.cavalotti@… | Owned by: | cboos |
|---|---|---|---|
| Priority: | lowest | Milestone: | 0.10 |
| Component: | general | Version: | 0.8 |
| Severity: | trivial | Keywords: | layout |
| Cc: | kilian.cavalotti@…,maze@…,dfr@…,mjhweb-tractickets@…,trac@… | ||
| Release Notes: | |||
| API Changes: | |||
Description
In konqueror, the display of the diff table does not use the whole page width.
patch follows
--- diff.css.old 2004-12-21 02:17:36.000000000 +0100
+++ diff.css 2005-03-03 16:19:12.153776512 +0100
@@ -50,6 +50,7 @@
/* Styles for the list of diffs */
.diff ul { clear: both; margin: 0; padding: 0 }
.diff li {
+ width: 100%;
background: #f7f7f7;
border: 1px solid #d7d7d7;
list-style-type: none;
Another problem is that konqueror does not seems to take care of the overflow: hidden directive, but I can't figure why...
Attachments
Change History
comment:1 Changed 7 years ago by cmlenz
- Keywords layout added
- Milestone set to 0.9
- Owner changed from jonas to cmlenz
- Priority changed from normal to lowest
- Severity changed from minor to trivial
- Status changed from new to assigned
comment:2 Changed 7 years ago by cmlenz
comment:3 Changed 6 years ago by anonymous
- Cc maze@… added
comment:4 Changed 6 years ago by anonymous
- Cc dfr@… added
comment:5 Changed 6 years ago by cmlenz
- Milestone changed from 0.9 to 0.9.1
comment:6 Changed 6 years ago by cmlenz
- Milestone changed from 0.9.1 to 0.9.2
comment:7 Changed 6 years ago by cmlenz
- Milestone changed from 0.9.3 to 0.9.4
comment:8 Changed 6 years ago by anonymous
- Cc mjhweb-tractickets@… added
comment:9 Changed 6 years ago by dunerat@…
In Konqueror (KDE 3.5.1), the display of the diff table does not use the whole page width for first diffset only. It seems, that konqueror cannot correctly process tag "float" of preference table. Width of first diffset (in Konqueror) is screen_width - legend_tab_width - preference_tab_width or screen_width - preference_tab_width.
comment:10 Changed 6 years ago by trac@…
- Cc trac@… added
The patch in diff.css.patch fixes the problem in Konqueror 3.5.1. It's similar to the patch in the report, but taken against trunk.
comment:11 Changed 6 years ago by cmlenz
- Milestone changed from 0.9.4 to 0.9.5
Sorry, still not going to make it into 0.9.4... postponing again.
comment:13 Changed 6 years ago by cboos
- Owner changed from cmlenz to cboos
- Status changed from assigned to new
Was there something wrong with the width: 100% fix?
That change doesn't break IExplorer, Firefox, Opera 9 preview,
but I can't tell for Konqueror though.
comment:14 Changed 6 years ago by cboos
- Resolution set to fixed
- Status changed from new to closed
Patch applied in r3389, tentatively closing this as fixed.
#1331 has been marked as duplicate of this ticket.