InterWiki prefix with http works with more symbols then links defined without http

[martin.stolle@…]

The following definition in the wiki:InterMapTxt will not work with all symbols:

kwquery      /query?group=status&keywords=~  # Custom query for tickets matching keyword $1

in comparison to any prefix using http, e.g.

PEP     http://www.python.org/peps/pep-$1.html    # Python Enhancement Proposal

Example

Works

​kwquery:foo

Not working using an extra :

kwquery:foo:bar

Works

​PEP:foo:bar

[martin.stolle@…]

Open trac.ini, goto section wiki, add foo to safe_schemes, save and restart server.

https://trac.edgewall.org/wiki/TracIni

[Jun Omae]

No, no. This is not a safe_schemes issue.

[martin.stolle@…]

It clearly fixes the issue and save_schemes is a list of URI schemes considered "safe", that will be rendered as external links.

foo:bar is not safe because it needs to be defined as such.

If is not in safe_schemes issue please define what it is.

[Jun Omae]

Workaround is to use %3a instead of :, e.g. ​kwquery:foo%3abar.

[Jun Omae]

After the patch, kwquery:foo:bar would be rendered as /query?group=status&keywords=~foo%3Abar link.

trac/wiki/interwiki.py

@@ -22 +22 @@
 from trac.config import ConfigSection
 from trac.core import *
 from trac.util import lazy
+from trac.util.text import unicode_quote
 from trac.util.translation import _, N_
 from trac.wiki.api import IWikiChangeListener, IWikiMacroProvider, WikiSystem
 from trac.wiki.parser import WikiParser
@@ -69 +70 @@
         """Replace "$1" by the first args, "$2" by the second, etc."""
         def setarg(match):
             num = int(match.group()[1:])
-            return args[num - 1] if 0 < num <= len(args) else ''
-        return re.sub(InterWikiMap._argspec_re, setarg, txt)
+            return unicode_quote(args[num - 1]) if 0 < num <= len(args) else ''
+        return InterWikiMap._argspec_re.sub(setarg, txt)
 
     def _expand_or_append(self, txt, args):
         """Like expand, but also append first arg if there's no "$"."""
         if not args:
             return txt
         expanded = self._expand(txt, args)
-        return txt + args[0] if expanded == txt else expanded
+        return txt + unicode_quote(args[0]) if expanded == txt else expanded
 
     def url(self, ns, target):
         """Return `(url, title)` for the given InterWiki `ns`.

[Ryan J Ollos]

Moved ticket assigned to next-stable-1.0.x since maintenance of 1.0.x is coming to a close. Please move the ticket back if it's critical to fix on 1.0.x.

[Ryan J Ollos]

Milestone renamed