"log:" link wrongly checks LOG_VIEW for formatter context instead of repository

[Jun Omae]

When formatting log: link in ticket view, LogModule wrongly checks LOG_VIEW permission for ticket resource instead of repository resource. ChangesetModule correctly checks for repository resource.

Writing [1-42/trac.svn] and [1/trac.svn] in ticket comment after the following patch is applied:

trac/perm.py

@@ -471 +471 @@
                     self.log.debug("%s denies %s performing %s on %r",
                                    policy.__class__.__name__, username,
                                    action, resource)
+                else:
+                    self.log.debug("%s allowed %s performing %s on %r",
+                                   policy.__class__.__name__, username,
+                                   action, resource)
                 return decision
         self.log.debug("No policy allowed %s performing %s on %r",
                        username, action, resource)

The following would be logged.

2015-03-04 17:13:45,660 Trac[perm] DEBUG: DefaultPermissionPolicy allowed jun66j5 performing LOG_VIEW on <Resource u'ticket:2'>
2015-03-04 17:13:45,687 Trac[perm] DEBUG: DefaultPermissionPolicy allowed jun66j5 performing CHANGESET_VIEW on <Resource u'repository:trac.svn, changeset:1'>

Therefore, authz policy doesn't work in formatting log links.

The following patch would be good.

trac/versioncontrol/web_ui/log.py

@@ -397 +397 @@
                     repos = rm.get_repository(reponame)
 
             if repos:
-                if 'LOG_VIEW' in formatter.perm:
+                if 'LOG_VIEW' in formatter.perm(repos.resource):
                     revranges = None
                     if any(c in revs for c in ':-,'):
                         try:

[Christian Boos]

Change looks fine to me.

(stumbled upon this ticket when searching for an existing ticket involving RevRanges, before creating #12327)

[Jun Omae]

Thanks for the reviewing. I try to add unit tests for that.

[Jun Omae]

Proposed changes in log:jomae.git@t11972. I'll push it later.

[Jun Omae]

Committed in [14497] and merged to trunk in [14498].