Improve layout of report edit page

[Ryan J Ollos]

The styling of the Report Edit page could be improved and made more consistent with other Trac pages by adding a fieldset and making some other minor changes. This was first mentioned in comment:10:ticket:11499.

[Ryan J Ollos]

It seems the message extraction does not work correctly for this case,

<title py:choose="">
  <py:when test="new_report" i18n:msg="">Create New Report</py:when>
  <py:otherwise i18n:msg="id,title">Edit Report {$report.id} $report.title</py:otherwise>
</title>

but does for this case,

<py:choose test="new_report">
  <title py:when="True">Create New Report</title>
  <title py:otherwise="" i18n:msg="id,title">Edit Report {$report.id} $report.title</title>
</py:choose>

Tested with Genshi 0.7.

[Ryan J Ollos]

Proposed changes in log:rjollos.git:t11664. The last changeset on the branch ([b3f86bbf/rjollos.git])is a refactoring that is only intended for the trunk.

[Ryan J Ollos]

Does anyone know if there is any reason to leave the size attribute on input elements that have a CSS rule width: 100%? I was thinking it could be needed for older browsers, but in the testing with older versions on IE (in emulation mode) it doesn't seem to make a difference.

[Ryan J Ollos]

Minor revisions in log:rjollos.git:t11664.1.

It could be better to apply these changes to trunk for the reason described in comment:13:ticket:11499, but the current styling of the Report Edit page is inconsistent with other pages, which might suggest this should be fixed on 1.0-stable.

[Jun Omae]

Replying to rjollos:

Does anyone know if there is any reason to leave the size attribute on input elements that have a CSS rule width: 100%? I was thinking it could be needed for older browsers, but in the testing with older versions on IE (in emulation mode) it doesn't seem to make a difference.

Nothing is wrong to remove it. The width:100% property is used even if IE 6.

[Ryan J Ollos]

Thanks for the review. Committed to 1.0-stable in [12915], merged to trunk in [12916]. Refactoring committed to trunk in [12917].

[Ryan J Ollos]

I regenerated the catalogs in [12918] and [12919], but I don't have permissions to upload them to Transifex.

Do the translation reports in the milestone descriptions reflect the state of the language po files? Most of those haven't been updated from the latest pot, so I would expect the report to have artificially high percentages for most languages.

[Jun Omae]

I regenerated the catalogs in [12918] and [12919], but I don't have permissions to upload them to Transifex.

Same here. But it seems *.pot files is automatically fetched by transifex. See history in bottom of ​https://www.transifex.com/projects/p/trac/.

Do the translation reports in the milestone descriptions reflect the state of the language po files? Most of those haven't been updated from the latest pot, so I would expect the report to have artificially high percentages for most languages.

Yes, the reports seem to be right. I guess that most of translators probably work after announcing "string freeze". Also, in the group1 and group2 languages, translators have commit right and would directly push translations. In the group3 languages which translators have no commit right, we should commit *.po files from transifex.

[Ryan J Ollos]

The following issue was noted in comment:6:ticket:11678.

It seems that the rule trunk/trac/htdocs/css/report.css@12954:96#L84​ has no effect, but it would be good to have a small amout of spacing between the label and textarea.

Following the guidelines in ​this article, the following patch was generated:

trac/htdocs/css/report.css

@@ -93 +93 @@
  max-width: 54em;
 }
 #content.report .field { margin: 1em 0; }
-#content.report .field label { padding-bottom: .3em; }
+#content.report .field label {
+ display: block;
+ padding-bottom: .3em;
+}
 
 #query { clear: right }
 #query fieldset, #query fieldset input, #query fieldset select {

trac/ticket/templates/report_edit.html

@@ -36 +36 @@
           </legend>
           <input type="hidden" name="action" value="$action" />
           <div class="field">
-            <label for="title">Title:</label><br />
+            <label for="title">Title:</label>
             <input type="text" id="title" name="title" class="trac-autofocus" v
           </div>
           <div class="field">
             <label for="description" i18n:msg="">
               Description: (you may use <a tabindex="42" href="${href.wiki('Wik
-            </label><br />
+            </label>
             <textarea id="description" name="description" class="wikitext trac-
 $report.description</textarea>
           </div>
@@ -52 +52 @@
             </div>
             <label for="query" i18n:msg="">Query: (can be either SQL or, if sta
               a <a tabindex="42" href="${href.wiki('TracQuery') + '#QueryLangua
-            </label><br />
+            </label>
             <textarea id="query" name="query" class="trac-resizable" rows="20" 
 $report.sql</textarea>
           </div>

[Ryan J Ollos]

Change from comment:10 committed in [12981], merged in [12982].